Move threshold up for flaky test with Electra #6622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,7 +312,7 @@ def test_pt_tf_model_equivalence(self): | |||
| print(config) | |||
| print(inputs_dict) | |||
| print(pt_inputs_dict) | |||
| self.assertLessEqual(max_diff, 2e-2) | |||
| self.assertLessEqual(max_diff, 4e-2) | |||
There was a problem hiding this comment.
think we should update the if max_diff >= 2e-2: to 4-e2 as well.
There was a problem hiding this comment.
Didn't see it, thanks for catching that mistake!
patrickvonplaten
approved these changes
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #6622 +/- ##
==========================================
+ Coverage 79.01% 79.69% +0.68%
==========================================
Files 156 156
Lines 28217 28217
==========================================
+ Hits 22295 22487 +192
+ Misses 5922 5730 -192
Continue to review full report at Codecov.
|
|
Great, thanks for taking care of it! |
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
* Move threshold up for flaky test with Electra * Update above as well
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
* Move threshold up for flaky test with Electra * Update above as well
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…)" This reverts commit f16ebea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on slack, this should take care of the Electra flaky test with PT/TF equivalence.
@LysandreJik just a ping for when you're back so you're aware.