Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Publication Checklist feature #13

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Conversation

rmccue
Copy link
Member

@rmccue rmccue commented Jul 12, 2019

Fixes #12.

Still todo: requires Publication Checklist to be published to Packagist, then added to the composer.json here.

@rmccue
Copy link
Member Author

rmccue commented Jul 12, 2019

All sorted, requires humanmade/altis-core#42 as well.

@rmccue rmccue marked this pull request as ready for review July 12, 2019 14:39
@rmccue rmccue requested review from roborourke and joehoyle July 12, 2019 14:39
@joehoyle
Copy link
Member

Can we add the necessary documentation here too.

Copy link
Member

@joehoyle joehoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docs

@rmccue
Copy link
Member Author

rmccue commented Jul 12, 2019

Whoops, forgot to commit that! Sorted now.

I noticed actually that I was inconsistent with underscores and dashes for the options here; should I standardise on dashes?

@joehoyle joehoyle merged commit 00753f9 into master Jul 12, 2019
@joehoyle joehoyle deleted the add-publication-checklist branch July 12, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Publishing Checklist
2 participants