Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Update end time #393

Closed
felixhahnweilheim opened this issue Jun 15, 2023 · 1 comment · Fixed by #397
Closed

Automatically Update end time #393

felixhahnweilheim opened this issue Jun 15, 2023 · 1 comment · Fixed by #397
Assignees

Comments

@felixhahnweilheim
Copy link
Contributor

When creating/editing an event:

If you update the start date, the end date is updated, so that it is not before the start date.
Unfortunately, this does not happen with the time. So if you only change the time (to later), you can’t save the event because the end time is before the start time.

Suggestion:

If the start time is changed, check if the end date+time is before, if yes, update it to start time + 1 hour.


In many cases the end time is not so important, so a default of 1 hour is fine. And the suggestion would save users a few clicks (and an annoying error message).

@felixhahnweilheim
Copy link
Contributor Author

Also if the start date is updated, not only the end date should be updated but also the event time (if necessary).

Example
Start: 27 july 3pm
End: 28 july 11 am

You update the start date to 29 july (3pm remains). In that case the end date is automatically set to 29 july (11am remains).
So the end time is still before the start.

Generally I see 2 options (whenever start date or time are updated):

Option 1: Update and time to start time + 1 hour (e.g. 29 july 4pm).

Option 2: Remain the duration of the event (e.g. end: 30 july 11am).

I prefer option 2 because it is often that events have a fixed duration. But I would be fine with both.

@serh-mosk serh-mosk linked a pull request Jun 30, 2023 that will close this issue
luke- added a commit that referenced this issue Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants