Enh #393: Automatically Update end time #397
Conversation
|
@yuriimaz Thanks works well for me. Can we maybe separate the quite complex code for this into its own method/function and add some more comments. Possibly tests would also be good here. |
Added changing time test.
|
@luke- Simplified the time change code a bit. I added a test, but for some reason it failed for me precisely when checking the value of the field, which should have changed automatically. Although I tried to implement it in several ways. Very strange, but when I put a delay in the test and made changes manually, everything worked. Maybe you will be able to figure out what the reason is. |
|
@luke- I determined the cause of the failures in the creation of calendar events, due to which the tests fail. It is necessary to rollback changes to |
|
@yuriimaz Thank you for the investigation. I have searched all modules github.com/humhub & github.com/humhub-contrib and the function of Is it possible to find a solution specific to the Calendar module? @yurabakhtin What do you think? |
|
@luke- I think we can try to write similar code directly in the calendar module script. |
|
@yuriimaz Can you please do this? Then this module is also compatbile with the upcoming v1.15 |
@luke- Do you still need my help here? |
|
@yurabakhtin No thanks, I think everything is clear |
|
@yuriimaz Is it really enough to simply remove the lines? :-) |
|
@luke- When I checked everything was fine. But I checked again with a larger number of invitees to the event, so that pagination appears and when transitioning to another page of invitees, this block replaces the entire content of the modal window. Not sure if it's something to delete, but since it's a blocker, it needs fixing now. |
|
@yuriimaz Thanks looks good. Is it ready or are you still testing? |
|
@luke- Already checked, it's ready, should work fine |
No description provided.