Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI of create/edit form #405

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

felixhahnweilheim
Copy link
Contributor

PR for #392

  • moves the location field after the checkboxes "all day" and "recurring" -> so they are directly under date and time
  • makes date and time fields half width also on small screens (saves a lot of space on mobile)
  • the Time Zone always appears under the end time (also on mobile)

Screenshots before and after:

compare-calendar-PR

@luke-
Copy link
Contributor

luke- commented Jul 31, 2023

@felixhahnweilheim Thank you!

@Eladnarlea What do you think? Maybe we should create another issue for the editor under mobile?

@felixhahnweilheim
Copy link
Contributor Author

Just to make it clear, this PR does not affect the editor and the Description field.
(I just did the screenshots on different platforms (1.15 and 1.14) that's why there is a difference.)

@luke- luke- merged commit 159de91 into humhub:master Jul 31, 2023
@luke-
Copy link
Contributor

luke- commented Jul 31, 2023

@felixhahnweilheim Yes, thats clear. I've just merged your PR. Please also modify the CHANGELOG. I've added this change: d0070cf

@felixhahnweilheim felixhahnweilheim deleted the enh-edit-form branch July 31, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants