Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #6

Merged
merged 7 commits into from
May 8, 2024
Merged

Refactor #6

merged 7 commits into from
May 8, 2024

Conversation

rafal-gorecki
Copy link
Contributor

@rafal-gorecki rafal-gorecki commented Apr 30, 2024 •
edited
Loading

  • Clean up: Delete unnecessary files, reduce size from 63 MB to 28 MB
  • husarion_office.sdf: fix to work with gz Fortress and delete sensors from rosbot (some of them doesn't work and no need to simulate imu on static rosbot)
  • new launch file with some useful params

IMPORTANT
After merge please merge also following branches:

@rafal-gorecki rafal-gorecki requested a review from pawelirh May 6, 2024 08:34
pawelirh
pawelirh suggested changes May 6, 2024
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
worlds/meshes/husarion_world.dae Outdated Show resolved Hide resolved
worlds/models/ConfTable/meshes/ConfTable2.stl Outdated Show resolved Hide resolved
worlds/models/ConfTable/meshes/ConfTable2.stl Outdated Show resolved Hide resolved
worlds/models/ConfTable/meshes/ConfTable2.stl Outdated Show resolved Hide resolved
worlds/models/ConfTable/meshes/ConfTable2.stl Outdated Show resolved Hide resolved
worlds/husarion_world.sdf Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
README.md Show resolved Hide resolved
pawelirh
pawelirh reviewed May 6, 2024
View reviewed changes
launch/gz_sim.launch.py Outdated Show resolved Hide resolved
@rafal-gorecki rafal-gorecki requested a review from pawelirh May 6, 2024 14:34
pawelirh
pawelirh suggested changes May 7, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@rafal-gorecki rafal-gorecki requested a review from pawelirh May 8, 2024 09:20
@pawelirh pawelirh merged commit 3d0b9a0 into main May 8, 2024
@pawelirh pawelirh deleted the refactor branch May 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelirh pawelirh pawelirh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafal-gorecki @pawelirh