Ros2 manager plugins #232

delihus · 2024-02-26T21:02:12Z

Added panther_manager package
Added behaviotree-ros2 headers
Created call_set_bool_service as Behavior Tree Node
Created call_trigger_service as Behavior Tree Node
Created call_set_led_animation_service as Behavior Tree Node
Created shutdown_hosts_from_file_node as Behavior Tree Node
Created shutdown_single_host_node as Behavior Tree Node
Created signal_shutdown_node as Behavior Tree Node
Created tick_after_timeout_node as Behavior Tree Decorator
Tested all bt nodes

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

This reverts commit a4f9051.

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

KmakD

Please add behaviortree_ros2 to panther_hardware.repos and remove them from include. It will be build with colcon and you can simply include its files
plugins directory should be moved outside of src
missing tests for shutdown_host.hpp and shutdown_hosts_node.hpp
update includes

panther_manager/include/behaviortree_ros2/bt_action_node.hpp

panther_manager/include/panther_manager/plugins/action/call_set_bool_service_node.hpp

panther_manager/src/plugins/action/call_set_bool_service_node.cpp

panther_manager/include/panther_manager/plugins/action/call_set_led_animation_service_node.hpp

panther_manager/test/plugins/test_signal_shutdown_node.cpp

panther_manager/test/plugins/test_tick_after_timeout_node.cpp

…ugins

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

panther/panther_hardware.repos

panther_manager/src/plugins/action/call_set_bool_service_node.cpp

…on | removed unused warnings Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

…ing services when there are wrong parameters Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

panther_manager/plugins/action/shutdown_hosts_from_file_node.cpp

panther_manager/plugins/action/signal_shutdown_node.cpp

panther_manager/plugins/action/call_set_bool_service_node.cpp

panther_manager/plugins/action/shutdown_hosts_from_file_node.cpp

panther_manager/plugins/action/shutdown_single_host_node.cpp

panther_manager/test/plugins/test_call_trigger_service_node.cpp

panther_manager/test/plugins/test_shutdown_single_host_node.cpp

panther_manager/test/plugins/src/plugin_test_utils.cpp

panther_manager/test/plugins/test_tick_after_timeout_node.cpp

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

panther_manager/test/plugins/test_call_set_bool_service_node.cpp

panther_manager/test/plugins/test_shutdown_single_host_node.cpp

panther_manager/include/panther_manager/plugins/shutdown_hosts_node.hpp

panther_manager/include/panther_manager/plugins/shutdown_host.hpp

panther_manager/test/plugins/test_shutdown_host.cpp

panther_manager/test/plugins/test_shutdown_hosts_node.cpp

KmakD · 2024-03-25T07:24:57Z

panther_manager/test/plugins/test_shutdown_hosts_node.cpp

+  return true;
+}
+
+//  TODO: Create TESTs completely


Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

KmakD

We are tight on time so I finished this PR.
FYI, there were bug in test_shutdown_single_host where WrongCommand test would actually fail due to timeout not because of command. In fact wrong command wont cause ShutdownHost node to fail thats why also last test for test_shutdown_hosts was not working correctly. For now I disabled this test we'll have to dig more in future if we want to catch failures in shutdown commands. It still should work if ping for success is set - if command fail then host wont shutdown and timeout will be reached

delihus added 18 commits February 15, 2024 12:15

added behaviortree_ros2 to the repository because it is not in rosped

7561800

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

added set bool service

067feb5

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

added set bool service

411d328

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added trigger service call plugin

da67b2e

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added full call_set_bool plugin test

85f4d65

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added trigger tests

bed1fbe

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added tests for set animation plugin

7a5d74c

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added explicite casts

f933e45

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Moved pluigns to actions | added shutdown plugins

35ddb1e

Removed different types of building behavio tree

d84870b

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Fixed building trigger

4da02fa

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added tests for signal shutdown plugin

8512745

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

added test single plugin

93995d2

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

added test for single host plugin

a4f9051

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Revert "added test for single host plugin"

450b3bd

This reverts commit a4f9051.

Fixed tesT

bd066b3

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

tested on the robot

5b22b39

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

typo

75337ad

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

delihus requested a review from KmakD February 26, 2024 21:02

delihus added 2 commits February 28, 2024 15:51

Added TickAfterTimeout

0e21029

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

reverted panther_gazebo

428d201

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

delihus marked this pull request as draft March 6, 2024 07:31

added tests for tick_after_timeout

32ec819

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

delihus marked this pull request as ready for review March 6, 2024 15:48

KmakD requested changes Mar 11, 2024

View reviewed changes

KmakD mentioned this pull request Mar 14, 2024

Ros2 panther manager #246

Merged

delihus added 4 commits March 15, 2024 08:22

Merge remote-tracking branch 'origin/ros2-devel' into ros2-manager-pl…

f498161

…ugins

Added package suggestions without tests

3f58a58

Changed utils names and moved start stop to constructor and destructor

8295f4c

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

applied panther_utils

ea26a37

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

delihus marked this pull request as draft March 15, 2024 17:29

KmakD reviewed Mar 18, 2024

View reviewed changes

panther/panther_hardware.repos Outdated Show resolved Hide resolved

panther_manager/src/plugins/action/call_set_bool_service_node.cpp Outdated Show resolved Hide resolved

delihus added 5 commits March 20, 2024 08:24

Made fixed commit for behaviortreee | templated create service functi…

d975d61

…on | removed unused warnings Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added RegisterNode template function

98d6d69

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Changed tests' names to PascalCase | added testing::TempDir() | Start…

67c3182

…ing services when there are wrong parameters Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

fixed tests

f59ab95

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

fixed tick after timeout node

e1b040a

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

KmakD requested changes Mar 22, 2024

View reviewed changes

delihus added 2 commits March 22, 2024 10:43

fixed user to username | added test_shutdown_host

7084b46

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added all suggestions

40a5d44

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

delihus marked this pull request as ready for review March 22, 2024 12:44

delihus requested a review from KmakD March 22, 2024 12:44

KmakD requested changes Mar 25, 2024

View reviewed changes

delihus added 2 commits March 25, 2024 09:00

Add suggestions

ffe5c93

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

Added shutdonw hosts node

4af614e

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

delihus requested a review from KmakD March 25, 2024 12:38

delihus and others added 2 commits March 25, 2024 21:18

Fixed typo | cleaned up the test_shutdown_hosts_node

e4f9522

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>

fix tests

115ddb7

KmakD reviewed Mar 26, 2024

View reviewed changes

KmakD approved these changes Mar 26, 2024

View reviewed changes

KmakD merged commit 245429e into ros2-devel Mar 26, 2024

KmakD deleted the ros2-manager-plugins branch March 26, 2024 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ros2 manager plugins #232

Ros2 manager plugins #232

delihus commented Feb 26, 2024 •

edited

Loading

KmakD left a comment •

edited

Loading

KmakD Mar 25, 2024

KmakD left a comment

Ros2 manager plugins #232

Ros2 manager plugins #232

Conversation

delihus commented Feb 26, 2024 • edited Loading

KmakD left a comment • edited Loading

Choose a reason for hiding this comment

KmakD Mar 25, 2024

Choose a reason for hiding this comment

KmakD left a comment

Choose a reason for hiding this comment

delihus commented Feb 26, 2024 •

edited

Loading

KmakD left a comment •

edited

Loading