-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros2 panther manager #246
Ros2 panther manager #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some doubts regarding the architecture (coupling between different behavior trees). I'm not sure if at this exact moment, we want to pay attention to such a discussion. However, let me mention a few aspects.
- The states (received messages) are updated on the blackboard frequently.
- It's hard to scale. A new BT, or modification of an existing one demands changes in the core node and pulls after unit test modifications.
- Single responsibility for the node is not kept, since the node in this example is responsible for creating and configuring the BT and blackboard.
- Why do we push to have several independent trees, since they are in the end using the same resources and executing interchangeably (SingleThreadedExecutor)?
My mistake, this should be MultiThreadedExecutor. It's fixed. The idea behind two separate BTs is that safety is a crucial part of system and should be handled independently, we don't want deadlock or some sleep behavior in lights affect safety features. |
…nther_ros into ros2-panther-manager
…into ros2-panther-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏼
…into ros2-panther-manager
Most of the work is done, can't be merged as it is waiting for plugin PR first. Plugin PR should include merging newest ros2-devel branch.
Things to finish after plugins are added: