ROS 2 remove obsolate tests

[KmakD]

Description

Remove tests that are no longer necessary. The type mismatch check is performed during tree creation inside factory. This tests do not check any part of our code so there is no point having them.

Also, remove unnecessary brackets inside lights.xml

Modifications

Summary by CodeRabbit

• Refactor

  • Simplified logical expression for setting animations to improve readability.

• Tests

  • Removed test cases for incorrect service values to streamline the test suite.

[coderabbitai]

Walkthrough

The recent changes involve simplifying a condition in the lights.xml file within the panther_manager/behavior_trees directory and removing several test cases from test_call_set_bool_service_node.cpp and test_call_set_led_animation_service_node.cpp. These modifications streamline the logic and testing procedures by eliminating unnecessary parentheses and outdated test cases.

Changes

Files	Change Summary
panther_manager/behavior_trees/lights.xml	Simplified the _skipIf attribute condition by removing unnecessary parentheses.
panther_manager/test/plugins/test_call_set_bool_service_node.cpp	Removed the WrongServiceValueDefined test case.
panther_manager/test/plugins/test_call_set_led_animation_service_node.cpp	Removed the WrongRepeatingServiceValueDefined and WrongIdServiceValueDefined test cases.

Poem

In Panther's code, a tweak so bright,
Simplified the logic light. 🌟
Tests removed, no longer needed,
Streamlined paths now unimpeded.
With every change, we see the might,
Of Panther's journey to new height! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c600d57 and 38c5f6a.

Files selected for processing (3)

• panther_manager/behavior_trees/lights.xml (1 hunks)
• panther_manager/test/plugins/test_call_set_bool_service_node.cpp (1 hunks)
• panther_manager/test/plugins/test_call_set_led_animation_service_node.cpp (1 hunks)

Files skipped from review due to trivial changes (2)

• panther_manager/test/plugins/test_call_set_bool_service_node.cpp
• panther_manager/test/plugins/test_call_set_led_animation_service_node.cpp

Additional comments not posted (1)

panther_manager/behavior_trees/lights.xml (1)

52-52: Simplified logical expression in _skipIf attribute enhances readability.