v3.0.0-rc.2 #180
Merged
v3.0.0-rc.2 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for Secret Service support.
1. Add set_secret and get_secret entries to credentials and keystores and tests. 2. Rename delete_password to delete_credential everywhere. This fixes hwchen#174.
1. If a password to be set can be interpreted as base64-encoded data, it's set as the secret, otherwise it's set as the password. 2. The get command has been split into password and secret commands, with the latter returning a base64-encoded string of the binary secret.
1. It's now named keyring-cli, so it's easy to cargo install. 2. Clean up use of word "password" in error messages.
Also cache the dependencies on native builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the binary secret functionality. Update the tests, the CLI, the docs, and the workflows.