Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the datetime formats in the DateString class to class constants #554

Closed
caendesilva opened this issue Oct 2, 2022 · 0 comments
Closed

Extract the datetime formats in the DateString class to class constants #554

caendesilva opened this issue Oct 2, 2022 · 0 comments
Labels
contributors-welcome Want something to do? Look here! good first issue Good for newcomers hacktoberfest

Comments

@caendesilva
Copy link
Member

This would make it easier for those who build sites using the Framework to display date formats in the same format as Hyde does.

So for example, instead of $this->dateTimeObject->format('M jS, Y'); we'd use $this->dateTimeObject->format(self::SHORT_FORMAT);

The constants should be public class members of the DateString class.
@caendesilva caendesilva added good first issue Good for newcomers contributors-welcome Want something to do? Look here! hacktoberfest labels Oct 2, 2022
@cdterry87 cdterry87 mentioned this issue Oct 2, 2022
Merged
caendesilva pushed a commit to hydephp/framework that referenced this issue Oct 2, 2022
Merge pull request #555 from cdterry87/master
7fb0b8f 
Extracted the datetime formats in the DateString class to class constants

Fixes hydephp/develop#554 hydephp/develop@ff88b13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributors-welcome Want something to do? Look here! good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caendesilva