Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted the datetime formats in the DateString class to class constants #555

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Conversation

cdterry87
Copy link
Contributor

No description provided.

@cdterry87
Copy link
Contributor Author

Hi @caendesilva , I have submitted a pull request related to issue #554 . Please let me know if interpreted anything incorrectly and I can make corrections. Thanks!

Copy link
Member

@caendesilva caendesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #555 (70038c1) into master (a11b531) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #555   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       972       972           
===========================================
  Files            113       113           
  Lines           2405      2405           
===========================================
  Hits            2405      2405           
Impacted Files Coverage Δ
...ckages/framework/src/Models/Support/DateString.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit ff88b13 into hydephp:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants