Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: #9 #10

Merged
merged 1 commit into from
Mar 29, 2022
Merged

refactor: #9 #10

merged 1 commit into from
Mar 29, 2022

Conversation

hyesungoh
Copy link
Owner

기존 json 파일을 destructing import를 할 수 없어, 사용처에서 import 후 destructing 하였습니다.

이를 refactoring하기 위해 _config directory의 index 파일을 두어 export한 후, 사용처에서 아래와 같은 모습으로 사용할 수 있게끔 하였습니다.

import {.blogUrl } from "../_config";

@hyesungoh hyesungoh added the refactor This seems like refactorable label Mar 29, 2022
@vercel
Copy link

vercel bot commented Mar 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

comet-land-blog – ./apps/blog

🔍 Inspect: https://vercel.com/hyesungoh/comet-land-blog/u8rw7TWVFBt5tWvmH3AL6gjwzgBn
✅ Preview: https://comet-land-blog-git-refactor-9-hyesungoh.vercel.app

comet-land-resume – ./apps/resume

🔍 Inspect: https://vercel.com/hyesungoh/comet-land-resume/DjKofTFmR5i8Ej2s1rJH7LzoSZ1a
✅ Preview: https://comet-land-resume-git-refactor-9-hyesungoh.vercel.app

@hyesungoh hyesungoh linked an issue Mar 29, 2022 that may be closed by this pull request
@hyesungoh hyesungoh merged commit 656d993 into main Mar 29, 2022
@hyesungoh hyesungoh deleted the refactor/#9 branch April 5, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor This seems like refactorable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrapping _config/index.json
1 participant