Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply test at Resume constants #46

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Apply test at Resume constants #46

merged 2 commits into from
Apr 23, 2022

Conversation

hyesungoh
Copy link
Owner

Apply test code at Resume app's constant directory

and refactor it

as is

using openEmailTo function for anchor tag with emailto:

to be

replace openExternalLink utils at core

@hyesungoh hyesungoh added refactor This seems like refactorable test: unit Apply new unit test or request test code labels Apr 23, 2022
@vercel
Copy link

vercel bot commented Apr 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

comet-land-blog – ./apps/blog

🔍 Inspect: https://vercel.com/hyesungoh/comet-land-blog/FWZhbKQPkNsvN2dhe3Jb8UceeRHy
✅ Preview: https://comet-land-blog-git-45-hyesungoh.vercel.app

comet-land-resume – ./apps/resume

🔍 Inspect: https://vercel.com/hyesungoh/comet-land-resume/9BgiLntxkjTQZoARK22JCUhZAXd6
✅ Preview: https://comet-land-resume-git-45-hyesungoh.vercel.app

@hyesungoh hyesungoh linked an issue Apr 23, 2022 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #46 (6080a9e) into main (68db326) will increase coverage by 1.85%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   54.53%   56.39%   +1.85%     
==========================================
  Files         102      102              
  Lines        2919     2917       -2     
  Branches      485      485              
==========================================
+ Hits         1592     1645      +53     
+ Misses       1327     1272      -55     
Impacted Files Coverage Δ
...ps/resume/src/constants/KbarActions/KbarActions.ts 93.93% <100.00%> (+93.93%) ⬆️
apps/resume/src/constants/KbarActions/index.ts 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d5029...6080a9e. Read the comment docs.

@cypress
Copy link

cypress bot commented Apr 23, 2022



Test summary

1 0 0 0


Run details

Project blog
Status Passed
Commit 9f760b9 ℹ️
Started Apr 23, 2022 10:57 AM
Ended Apr 23, 2022 10:57 AM
Duration 00:16 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 23, 2022



Test summary

1 0 0 0


Run details

Project resume
Status Passed
Commit 9f760b9 ℹ️
Started Apr 23, 2022 10:58 AM
Ended Apr 23, 2022 10:58 AM
Duration 00:14 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@hyesungoh hyesungoh merged commit c995ac0 into main Apr 23, 2022
@hyesungoh hyesungoh deleted the #45 branch April 23, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor This seems like refactorable test: unit Apply new unit test or request test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply test at Resume app's constants
1 participant