Android: isAcknowledgedAndroid should be available for subscriptions

[zs-doron]

Version of react-native-iap

3.4.12

Version of react-native

0.60

Platforms you faced the error (IOS or Android or both?)

Android

Expected behavior

isAcknowledgedAndroid should be set for both SKU types to allow for cleanly checking whether a purchase should be acknowledged.

Actual behavior

isAcknowledgedAndroid is only set for SKU types "IAP", not for subscriptions. However, subscriptions need to be acknowledged, too (see Billing library documentation). Currently, you have to check the purchase's transactionReceipt to see if the purchase has been acknowledged, or always acknowledge the purchase.

        if (type.equals(BillingClient.SkuType.INAPP)) {
          item.putBoolean("isAcknowledgedAndroid", purchase.isAcknowledged());
        } else if (type.equals(BillingClient.SkuType.SUBS)) {
          item.putBoolean("autoRenewingAndroid", purchase.isAutoRenewing());
        }

Tested environment (Emulator? Real Device?)

Steps to reproduce the behavior

[hyochan]

Thanks for the issue! Fixed in 3.5.6. Consider giving PR for the next time 😀

[zs-doron]

Thanks, I wanted to discuss it first before fixing it, next time I will add a PR. See PR #752 to fix the typings related to this issue.