Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings: Move isAcknowledgedAndroid to ProductPurchase #752

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

zs-doron
Copy link
Contributor

@zs-doron zs-doron commented Oct 3, 2019

Since after fixing #748 isAcknowledgedAndroid is available for both InAppPurchase and SubscriptionPurchase, I have moved the property to the common base interface ProductPurchase

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable!

@hyochan hyochan added 🍗 enhancement New feature or request lint labels Oct 4, 2019
@hyochan hyochan merged commit ac5d064 into hyochan:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants