Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

add grpc api of container signal #401

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Conversation

Crazykev
Copy link
Contributor

@Crazykev Crazykev commented Aug 5, 2016

Signed-off-by: haozhang crazykev@zju.edu.cn

@@ -614,3 +614,17 @@ func (c *HyperClient) Info() (*types.InfoResponse, error) {

return info, nil
}

// ContainerSignal sends a signal to specified container of specified pod
func (c *HyperClient) ContainerSignal(podID, containerID string, signal int64) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the test code to call it?

@Crazykev
Copy link
Contributor Author

@laijs added test case

@laijs laijs closed this Sep 12, 2016
@laijs laijs reopened this Sep 12, 2016
@Crazykev
Copy link
Contributor Author

@laijs updated and rebased.

message ContainerSignalRequest {
string podID = 1;
string containerID = 2;
int64 signal = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please fix the indent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, rely too much on gofmt, fixed that.

@laijs
Copy link
Contributor

laijs commented Dec 21, 2016

need rebase. see #482

@gnawux
Copy link
Member

gnawux commented Dec 21, 2016

woo... Sorry for introduce conflict for you...

@Crazykev
Copy link
Contributor Author

Rebased.
@gnawux either of us need to do that 😉

@laijs
Copy link
Contributor

laijs commented Dec 21, 2016

I1221 05:21:54.559450   22372 server.go:152] Calling GET /v0.7.0/images/get
# github.com/hyperhq/hyperd/integration
/home/travis/gopath/src/github.com/hyperhq/hyperd/integration/hyper_test.go:517: too many arguments in call to s.client.StartPod
FAIL	github.com/hyperhq/hyperd/integration [build failed]
!!! Error in /home/travis/gopath/src/github.com/hyperhq/hyperd/hack/lib/test.sh:129
  'go test github.com/hyperhq/hyperd/integration -check.vv -v' exited with status 2
Call stack:
  1: /home/travis/gopath/src/github.com/hyperhq/hyperd/hack/lib/test.sh:129 hyper::test::integration(...)
  2: hack/test-cmd.sh:161 runTests(...)
  3: hack/test-cmd.sh:191 main(...)
Exiting with status 1
I1221 05:21:59.463920   22372 daemon.go:345] The daemon will be shutdown
I1221 05:21:59.464034   22372 daemon.go:346] Shutdown all VMs
+++ [1221 05:21:59] Clean up complete

Signed-off-by: haozhang <crazykev@zju.edu.cn>
@Crazykev
Copy link
Contributor Author

@laijs fixed. Seems failure in CI not concerned with this patch.

!!! Error in /home/travis/gopath/src/github.com/hyperhq/hyperd/hack/lib/test.sh:51
'sudo env PATH=$PATH hyperctl run --rm -a -p $1' exited with status 1
Call stack:
1: /home/travis/gopath/src/github.com/hyperhq/hyperd/hack/lib/test.sh:51 hyper::test::run_attached_pod(...)
2: /home/travis/gopath/src/github.com/hyperhq/hyperd/hack/lib/test.sh:67 hyper::test::insert_file(...)
3: hack/test-cmd.sh:171 runTests(...)
4: hack/test-cmd.sh:191 main(...)
Exiting with status 1

@laijs laijs closed this Dec 21, 2016
@laijs laijs reopened this Dec 21, 2016
@laijs
Copy link
Contributor

laijs commented Dec 22, 2016

close it, and reopen it later with the hope that it will be tested with the newest hyperd

@laijs laijs closed this Dec 22, 2016
@Crazykev Crazykev reopened this Jan 12, 2017
@Crazykev
Copy link
Contributor Author

@laijs travis can pass now.

@feiskyer feiskyer closed this Jan 12, 2017
@feiskyer feiskyer reopened this Jan 12, 2017
@gnawux
Copy link
Member

gnawux commented Jan 12, 2017

retest this please, @hykins

@feiskyer feiskyer merged commit 763fcd8 into hyperhq:master Jan 12, 2017
@Crazykev Crazykev deleted the add-grpc-signal branch January 12, 2017 04:27
@laijs
Copy link
Contributor

laijs commented Jan 12, 2017

could you also add the signal api for process(exec) please?

@Crazykev
Copy link
Contributor Author

@laijs yep, will do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants