-
Notifications
You must be signed in to change notification settings - Fork 193
Conversation
@@ -614,3 +614,17 @@ func (c *HyperClient) Info() (*types.InfoResponse, error) { | |||
|
|||
return info, nil | |||
} | |||
|
|||
// ContainerSignal sends a signal to specified container of specified pod | |||
func (c *HyperClient) ContainerSignal(podID, containerID string, signal int64) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are the test code to call it?
7c2583a
to
4e160b1
Compare
@laijs added test case |
4e160b1
to
5ef0f92
Compare
@laijs updated and rebased. |
message ContainerSignalRequest { | ||
string podID = 1; | ||
string containerID = 2; | ||
int64 signal = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please fix the indent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, rely too much on gofmt, fixed that.
5ef0f92
to
012d492
Compare
need rebase. see #482 |
woo... Sorry for introduce conflict for you... |
012d492
to
497b4ec
Compare
Rebased. |
|
Signed-off-by: haozhang <crazykev@zju.edu.cn>
497b4ec
to
d0da4df
Compare
@laijs fixed. Seems failure in CI not concerned with this patch.
|
close it, and reopen it later with the hope that it will be tested with the newest hyperd |
@laijs travis can pass now. |
retest this please, @hykins |
could you also add the signal api for process(exec) please? |
@laijs yep, will do |
Signed-off-by: haozhang crazykev@zju.edu.cn