This repository was archived by the owner on Feb 8, 2021. It is now read-only.
separate start and attach in the client side #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang Xu <gnawux@gmail.com>
gnawux
force-pushed
the
client_attach
branch
2 times, most recently
from
6693eda to
6b4a8f3
Compare
client may issue an attach before start Signed-off-by: Wang Xu <gnawux@gmail.com>
gnawux
force-pushed
the
client_attach
branch
from
6b4a8f3 to
7027839
Compare
Signed-off-by: Wang Xu <gnawux@gmail.com>
14 tasks
gnawux
force-pushed
the
client_attach
branch
from
0c87321 to
0024210
Compare
//TODO: remove the tty stream in StartPod API, now we could support attach after created //Done. Signed-off-by: Wang Xu <gnawux@gmail.com>
gnawux
force-pushed
the
client_attach
branch
from
0024210 to
48122d8
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wang Xu gnawux@gmail.com