elongating startInstance response

[PGoku]

• I confirm that this is an issue rather than a question.

Bug report

Hey,
first of all: thank you for your very good work !
I found an issue with the responses of the instance handling.
In case someone got more than the main hardware led instance there is a bug with the response from hyperion.ng - or to be more clearly: with the amount of items inside the response - but this behaviour is only happening while starting instances.
I didn't recognize a problem with other responses / modules yet.
i also didn't saw this inside the webinterface (system -> protocol).

the only way i found to reset this elongating response is to stop the hyperion.ng service on my rpi and start it again, than its (only for the first started instance) working as expected and start to accumulating the success messages again.

Steps to reproduce

start an instance (1 success entry inside the response),
stop an instance,
start an instance again (2success entries),
...

What is expected?

the response after the "startInstance" command should be everytime like this:

{"command":"instance-update","data":[{"friendly_name":"","instance":0,"running":true},{"friendly_name":"","instance":1,"running":true},{"friendly_name":"","instance":2,"running":true}]}
{"command":"instance-startInstance","success":true,"tan":0}

What is actually happening?

this is ONE response i received - NOT multiple ones.
i copied it after the 18. start of an instance.
only the success messages accumulating as the following log should clarify:

{"command":"instance-update","data":[{"friendly_name":"","instance":0,"running":true},{"friendly_name":"","instance":1,"running":true},{"friendly_name":"","instance":2,"running":true}]}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}
{"command":"instance-startInstance","success":true,"tan":0}

System

Hyperion Server:

• Build: (HEAD detached at 2.0.14) (LordGrey-c9a1c88/b109703-1669566414)
• Build time: Nov 27 2022 18:59:24
• Git Remote: https://github.com/hyperion-project/hyperion.ng
• Version: 2.0.14
• UI Lang: de (BrowserLang: de-DE)
• UI Access: expert
• Avail Screen Cap.: dispmanx,framebuffer,qt
• Avail Video Cap.: v4l2
• Avail Services: boblight,cec,effectengine,forwarder,flatbuffer,protobuffer,mDNS,SSDP,borderdetection
• Config path: /opt/hyperion
• Database: read/write

Hyperion Server OS:

• Distribution: Raspbian GNU/Linux 11 (bullseye)
• Architecture: arm
• CPU Model: ARMv7 Processor rev 3 (v7l)
• CPU Type: Raspberry Pi 4 Model B Rev 1.5
• CPU Revision: c03115
• CPU Hardware: BCM2711
• Kernel: linux (5.15.56-v7l+ (WS: 32))
• Root/Admin: false
• Qt Version: 5.15.2
• Python Version: 3.9.2
• Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36

[Lord-Grey]

Thank you for sharing your observations.
Looks like, we need to have closer look what is happening here…

[Lord-Grey]

@PGoku The Bug is fixed, you can test it via PR #1549

[PGoku]

Hey @Lord-Grey,
i'm running out of space thats why i can't compile it myself at the moment because i don't have the needed software on this machine right now.
I need to wait for a precompiled nightly-build to tell you if this fix the issue.
Sorry for the inconvenience.

[Lord-Grey]

@PGoku No Problem. It can be still tested when the PR has been merged via the nightly builds.

[PGoku]

I tested your fix today (nightly build).
Now I only get the amount of messages I expect - It works like a charm :)

[Lord-Grey]

Thanks for your feedback.
Great that it works.