Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Fixes/Updates #1549

Merged
merged 16 commits into from
Jan 16, 2023
Merged

Various Fixes/Updates #1549

merged 16 commits into from
Jan 16, 2023

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Dec 29, 2022 •
edited
Loading

Summary

Added

  • cmake support of libcec without version in lib-name

Changed

  • Various clean-ups

Fixed

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Fixes #1544
Fixes #1551

@Lord-Grey Lord-Grey self-assigned this Dec 29, 2022
@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm the Hyperion Project Bot and I want to thank you for
contributing to Hyperion with your pull requests!

To help you and other users test your pull requests faster,
I'll create a link for you to your workflow artifacts.

🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3801649289

Of course, if you make changes to your PR, I will create a new link.

Best regards,
Hyperion Project

@Lord-Grey Lord-Grey mentioned this pull request Dec 29, 2022
Closed
1 task
@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3809775856

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3809775856

@Lord-Grey Lord-Grey mentioned this pull request Dec 31, 2022
Closed
1 task
@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3831042315

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3877075656

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3928307785

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3928948608

@Lord-Grey Lord-Grey merged commit fa7a5b6 into hyperion-project:master Jan 16, 2023
asturel pushed a commit to asturel/hyperion.ng that referenced this pull request Feb 11, 2023
@Lord-Grey @asturel
Various Fixes/Updates (hyperion-project#1549)
aeb2c52 
* Update FindWindowsSDK.cmake

* cmake support libcec without version

* Ensure Light-Ids are strings

* Fix type - do not have dbus as requried

* Fixing hyperion-project#1544

* Cleanup

* CleanupFix hyperion-project#1551

* Consistently return instance number with JSON replies (hyperion-project#1504)

* hyperion-remote- Fix extracting reply for configGet request

* Qt 6.6 - Fix iterator finds

* Fix test_image2ledsmap

* Ensure window.currentHyperionInstanceName is set, cleanup system/log clipboard report

* Address protobuf cmake warning

* Update License

* Update ChangeLog

* Address CodeQL and clang findings
@Lord-Grey Lord-Grey deleted the Fixes branch February 16, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Lord-Grey Lord-Grey

Labels
Bug Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elongating startInstance response Hyperion.ng not detecting/connecting into the Hue bridge
1 participant
@Lord-Grey