Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add too_many_resets debug_data to the GOAWAY we send #3211

Closed
seanmonstar opened this issue Apr 25, 2023 · 0 comments · Fixed by hyperium/h2#678
Closed

Add too_many_resets debug_data to the GOAWAY we send #3211

seanmonstar opened this issue Apr 25, 2023 · 0 comments · Fixed by hyperium/h2#678
Labels
A-http2 Area: HTTP/2 specific. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

There was a new GOAWAY added in hyperium/h2#668. It would be helpful to send some extra debug data in the GOAWAY so that peers can know they hit a limit. This is now easier thanks to #3200.
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-http2 Area: HTTP/2 specific. C-refactor Category: refactor. This would improve the clarity of internal code. labels Apr 25, 2023
@Herbstein Herbstein mentioned this issue Apr 26, 2023
Merged
seanmonstar pushed a commit to hyperium/h2 that referenced this issue Apr 28, 2023
@Herbstein
Add too_many_resets debug_data to the GOAWAY we send (#678)
70eade5 
Closes hyperium/hyper#3211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-http2 Area: HTTP/2 specific. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add too_many_resets debug_data to the GOAWAY we send Herbstein/h2
1 participant
@seanmonstar