Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup code in connection state update. #876

Merged
merged 3 commits into from
Jul 27, 2016
Merged

Dedup code in connection state update. #876

merged 3 commits into from
Jul 27, 2016

Conversation

leoyvens
Copy link
Contributor

Deduplicate and refactor code in State.update. The method is now more concise. Formatted with rustfmt because I got lazy to format it manually, but I may do that if it is preferable.

@GitCop
Copy link

GitCop commented Jul 27, 2016

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: 4e0253f
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: 28746fc
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: a9eec2d
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@seanmonstar
Copy link
Member

Great! I'll look it over more closely a bit later, as this method is tricky/dangerous.

@seanmonstar seanmonstar merged commit 1b4a2b7 into hyperium:master Jul 27, 2016
@seanmonstar
Copy link
Member

This is excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants