Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer overflow when building for ARM7 #133

Closed
twystd opened this issue Nov 3, 2020 · 4 comments · Fixed by #134
Closed

Integer overflow when building for ARM7 #133

twystd opened this issue Nov 3, 2020 · 4 comments · Fixed by #134

Comments

@twystd
Copy link

twystd commented Nov 3, 2020

Building a target for ARM7 (go build env GOOS=linux GOARCH=arm GOARM=7 ...) with a project that depends on grule-rule-engine v1.6.2 fails with the following error:

env GOOS=linux   GOARCH=arm GOARM=7 go build -o dist/development/arm7    ./...
# github.com/hyperjumptech/grule-rule-engine/antlr/parser/grulev2
../../../go/pkg/mod/github.com/hyperjumptech/grule-rule-engine@v1.6.2/antlr/parser/grulev2/grulev2_parser.go:1255: constant 4026532015 overflows int
../../../go/pkg/mod/github.com/hyperjumptech/grule-rule-engine@v1.6.2/antlr/parser/grulev2/grulev2_parser.go:2835: constant 4034920623 overflows int
@niallnsec
Copy link
Collaborator

This seems to be related to antlr/antlr4#2433

@newm4n
Copy link
Member

newm4n commented Nov 4, 2020

@niallnsec So we have to do this every time antler4 done generating parsers ?
Can we automate this some how ? Any Ideas ?

@niallnsec
Copy link
Collaborator

Yeah we would have to apply the patch every time the parsers are regenerated. I think we could automate the process with a go generate tag though.
I'll see if I can make it work and update later on.

@twystd
Copy link
Author

twystd commented Nov 5, 2020

Confirmed that I can now build for ARM7 - thanks for the quick turnaround!

twystd added a commit to uhppoted/uhppoted-httpd that referenced this issue Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants