Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-azure-kv): complete request handler and endpoints #1010

Closed
jagpreetsinghsasan opened this issue Jun 5, 2021 · 5 comments · Fixed by #1206
Closed

feat(keychain-azure-kv): complete request handler and endpoints #1010

jagpreetsinghsasan opened this issue Jun 5, 2021 · 5 comments · Fixed by #1206
Labels
enhancement New feature or request good-first-issue Good for newcomers good-first-issue-100-introductory Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to complete the code to enable the endpoints
get-keychain-entry
set-keychain-entry
delete-keychain-entry (or maybe use set-keychain-entry with tags for deletion)
Also, write tests that use the API client instead of the plugin instance directly.

Acceptance Criteria

  1. Update openapi.json at packages/cactus-plugin-keychain-azure-kv/src/main/json/openapi.json
  2. Update the endpoints at packages/cactus-plugin-keychain-azure-kv/src/main/typescript/webservices
  3. Update the remote adapter code at packages/cactus-plugin-keychain-azure-kv/src/main/typescript/plugin-keychain-azure-kv-remote-adapter.ts
  4. Update the test code at packages/cactus-plugin-keychain-azure-kv/src/test/typescript/integration/plugin-keychain-azure-kv.test.ts

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy @petermetz @TonyRowntree @travis-payne
@jagpreetsinghsasan jagpreetsinghsasan added enhancement New feature or request Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. labels Jun 5, 2021
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Jun 5, 2021
Merged
@petermetz
Copy link
Contributor

cc: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone

@Jeff-Ushry
Copy link
Contributor

Working on it now

@decommissioned-account
Copy link

@petermetz the cactus-plugin-keychain-azure-kv package doesn't exist - could it be an old name for a package that was since renamed?

Closed
@TonyRowntree
Copy link
Contributor

@petermetz the cactus-plugin-keychain-azure-kv package doesn't exist - could it be an old name for a package that was since renamed?

believe this issue is dependent on #991

@jagpreetsinghsasan
Copy link
Contributor Author

@ty-lazar the azure-kv plugin is still in PR, thus not yet visible in the code.

Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
a1a9ebe 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
@Leeyoungone Leeyoungone mentioned this issue Aug 20, 2021
Closed
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
d0be53e 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
10b30f4 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
96746c2 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
1d0c5ce 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
15dc7e6 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Aug 23, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
a822736 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
@Leeyoungone Leeyoungone mentioned this issue Aug 24, 2021
Merged
petermetz added a commit to Jeff-Ushry/cactus that referenced this issue Aug 27, 2021
@petermetz
feat(keychain-azure-kv): complete request handler and endpoints
c8bed36 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone pushed a commit to Jeff-Ushry/cactus that referenced this issue Sep 1, 2021
@petermetz @Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
49751ba 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Jeff-Ushry/cactus that referenced this issue Sep 3, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
5f508d1 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Jeff-Ushry/cactus that referenced this issue Sep 15, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
36bb741 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Jeff-Ushry/cactus that referenced this issue Sep 16, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
a729d70 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Jeff-Ushry/cactus that referenced this issue Sep 16, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
f3dd4a4 
Fixes hyperledger-cacti#1010

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Jeff-Ushry/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
97de9c7 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Jeff-Ushry/cactus that referenced this issue Sep 21, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
5284588 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Jeff-Ushry/cactus that referenced this issue Oct 1, 2021
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
0e571c6 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to Jeff-Ushry/cactus that referenced this issue Oct 1, 2021
@Leeyoungone @petermetz
feat(keychain-azure-kv): complete request handler and endpoints
5d87008 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to Jeff-Ushry/cactus that referenced this issue Apr 1, 2022
@Leeyoungone @petermetz
feat(keychain-azure-kv): complete request handler and endpoints
7bf53fe 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to Jeff-Ushry/cactus that referenced this issue Apr 1, 2022
@Leeyoungone @petermetz
feat(keychain-azure-kv): complete request handler and endpoints
13a288c 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to Jeff-Ushry/cactus that referenced this issue Apr 3, 2022
@Leeyoungone @petermetz
feat(keychain-azure-kv): complete request handler and endpoints
ebcefc0 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Apr 3, 2022
@Leeyoungone @petermetz
feat(keychain-azure-kv): complete request handler and endpoints
932df10 
Fixes #1010
Depends on #1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Apr 5, 2022
@Leeyoungone
feat(keychain-azure-kv): complete request handler and endpoints
445d8fc 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
micoferdinand98 pushed a commit to micoferdinand98/cactus that referenced this issue May 5, 2022
@Leeyoungone @micoferdinand98
feat(keychain-azure-kv): complete request handler and endpoints
679da5d 
Fixes hyperledger-cacti#1010
Depends on hyperledger-cacti#1349

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Jeffery Ushry <jeffery.ushry@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue Good for newcomers good-first-issue-100-introductory Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
5 participants
@petermetz @TonyRowntree @jagpreetsinghsasan @Jeff-Ushry @decommissioned-account