feat(keychain-azure-kv): complete request handler and endpoints #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leeyoungone
force-pushed
the
feat-1010-v2
branch
5 times, most recently
from
1d0c5ce to
15dc7e6
Compare
Primary Change
---
1. Added new package cactus-plugin-keychain-azure-kv under packages/
2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts
Resolves hyperledger-cacti#971
Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Fixes hyperledger-cacti#1010 Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone
force-pushed
the
feat-1010-v2
branch
from
15dc7e6 to
a822736
Compare
|
Because I got collaborator rights from Jeffery, I no longer need this PR. I will be closing this PR and work on #1206 for this issue. I apologize if there was any confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1010
This is might be a duplicate PR that Jeff's #1206 is working on, I'm opening a new PR since I do not have collaborator rights yet.