Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cacti-cmd-gui-app): rename to cacti-ledger-browser #2572

Closed
petermetz opened this issue Jul 24, 2023 · 4 comments · Fixed by #2575
Closed

refactor(cacti-cmd-gui-app): rename to cacti-ledger-browser #2572

petermetz opened this issue Jul 24, 2023 · 4 comments · Fixed by #2575
Assignees
Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. javascript Pull requests that update Javascript code P1 Priority 1: Highest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.

Comments

@petermetz
Copy link
Contributor

Rename the package to something more specific so that it doesn't squat on the entire
namespace of all GUI applications we ever wrote/will write.

This would be a breaking change but luckily we haven't released a new version of
it to npm yet so renaming it now is easy.

@petermetz petermetz added ConnectionChain Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. javascript Pull requests that update Javascript code P1 Priority 1: Highest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule. labels Jul 24, 2023
@petermetz petermetz self-assigned this Jul 24, 2023
petermetz added a commit to petermetz/cacti that referenced this issue Jul 24, 2023
Fixes hyperledger-cacti#2572

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@outSH
Copy link
Contributor

outSH commented Jul 25, 2023

Well, the GUI was meant to be common and extensible, I have a branch somewhere where each app is even separated from each other but I don't have time to push this forward. I see the point of making room for more GUI apps, but I don't like the name cacti-gui-tx-viewer since it already shows blocks, tokens and is meant to to much more in the future. Maybe cacti-gui-viewer / cacti-gui-browser ? Or something linked to persistence plugins, but I don't have any specific idea.

@izuru0 @takeutak

@izuru0
Copy link
Contributor

izuru0 commented Jul 26, 2023

I see the points made by both of @petermetz and @outSH
let me think about the name that is 'just right' for our app
wait for a day or two :)

@izuru0
Copy link
Contributor

izuru0 commented Jul 28, 2023

how about cacti-ledger-viewer or cacti-ledger-browser ?
these are specific enough to tell you that this lets you see ledger activity and broad enough that it isn't only about transactions

@petermetz
Copy link
Contributor Author

@outSH @izuru0 Sorry for the slow response! Fair points all around!

how about cacti-ledger-viewer or cacti-ledger-browser ?

Works for me! I see that @outSH thumbs-upped it as well, so I'll update the PR accordingly and re-request review! Thank you both!

@petermetz petermetz added this to the v2.0.0-alpha.2 milestone Aug 28, 2023
@petermetz petermetz changed the title refactor(cacti-cmd-gui-app): rename to cacti-gui-tx-viewer refactor(cacti-cmd-gui-app): rename to cacti-ledger-browser Aug 28, 2023
petermetz added a commit to petermetz/cacti that referenced this issue Aug 28, 2023
Fixes hyperledger-cacti#2572

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Aug 29, 2023
Fixes hyperledger-cacti#2572

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Aug 29, 2023
Fixes #2572

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
Fixes hyperledger-cacti#2572

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. javascript Pull requests that update Javascript code P1 Priority 1: Highest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants