Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cacti-cmd-gui-app): rename to cacti-ledger-browser #2575

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

petermetz
Copy link
Contributor

Fixes #2572

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just one quick question @petermetz , the folder itself has the old name, package/cacti-cmd-gui-app. So shouldn't we change that as well to have everything uniform?

@takeutak
Copy link
Contributor

takeutak commented Aug 8, 2023

@petermetz Sorry for my late replying (because I have been sick with covid for these two weeks...).
Almost LGTM, but there may be some risk that this name changing will cause some error of this application. I'm asking @izuru0 to check this PR and review it, so could you wait for a while?

@izuru0
Copy link
Contributor

izuru0 commented Aug 11, 2023

I'm ok with changing the name but my preference is to use cacti-ledger-viewer or cacti-ledger-browser
see the issue #2572 page

@petermetz petermetz self-assigned this Aug 28, 2023
@petermetz petermetz changed the title refactor(cacti-cmd-gui-app): rename to cacti-gui-tx-viewer refactor(cacti-cmd-gui-app): rename to cacti-ledger-browser Aug 28, 2023
@petermetz
Copy link
Contributor Author

@takeutak @izuru0 @outSH Thank you all for the feedback and the wait (and sorry for the slow responses as well)! I've renamed it according to the guidance to cacti-ledger-browser!

@takeutak Very sorry to hear about your sickness, I hope you've gotten over it since then or if not, then that you are very close it being done!

@petermetz petermetz added this to the v2.0.0-alpha.2 milestone Aug 28, 2023
Fixes hyperledger-cacti#2572

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz merged commit bd3c865 into hyperledger-cacti:main Aug 29, 2023
120 of 130 checks passed
@petermetz petermetz deleted the petermetz/issue2572 branch August 29, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(cacti-cmd-gui-app): rename to cacti-ledger-browser
5 participants