You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are not compliant with the RFC 7515 spec when it comes to our generated models.
Currently our OpenAPI spec generation has an issue with the models defined for representing RFC 7515 JSON Web Signatures 1 with the field protected being mangled by the OpenAPI generator because protected is a soft reserved keyword in Typescript.
Since protected is only a softly reserved keyword, this means that you can still declare classes/interfaces with fields that are called protected which is what we need since the RFC mentioned above declares exactly that for JWS recipients.
To Reproduce
Build the project and observe that the generated code looks like this:
This changes makes it so that model properties named `protected` will
no longer get mangled by the OpenAPI generator into `_protected`.
This is needed so that our generated models can be compliant with the
JWS RFC [1]
Since `protected` is only a softly reserved keyword, this means that
you can still declare classes/interfaces with fields that are called
`protected` which is what we need since the RFC mentioned above
declares exactly that for JWS recipients.
[1]: https://tools.ietf.org/html/rfc7515Fixeshyperledger-cacti#436
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This changes makes it so that model properties named `protected` will
no longer get mangled by the OpenAPI generator into `_protected`.
This is needed so that our generated models can be compliant with the
JWS RFC [1]
Since `protected` is only a softly reserved keyword, this means that
you can still declare classes/interfaces with fields that are called
`protected` which is what we need since the RFC mentioned above
declares exactly that for JWS recipients.
[1]: https://tools.ietf.org/html/rfc7515Fixes#436
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
(cherry picked from commit 7eb58a7)
This changes makes it so that model properties named `protected` will
no longer get mangled by the OpenAPI generator into `_protected`.
This is needed so that our generated models can be compliant with the
JWS RFC [1]
Since `protected` is only a softly reserved keyword, this means that
you can still declare classes/interfaces with fields that are called
`protected` which is what we need since the RFC mentioned above
declares exactly that for JWS recipients.
[1]: https://tools.ietf.org/html/rfc7515Fixes#436
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Describe the bug
We are not compliant with the RFC 7515 spec when it comes to our generated models.
Currently our OpenAPI spec generation has an issue with the models defined for representing RFC 7515 JSON Web Signatures 1 with the field
protected
being mangled by the OpenAPI generator becauseprotected
is a soft reserved keyword in Typescript.Since
protected
is only a softly reserved keyword, this means that you can still declare classes/interfaces with fields that are calledprotected
which is what we need since the RFC mentioned above declares exactly that for JWS recipients.To Reproduce
Build the project and observe that the generated code looks like this:
Expected behavior
The generated code should look like this:
Cloud provider or hardware configuration:
Dev machine
Operating system name, version, build:
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
v0.2.0
Hyperledger Cactus Plugins/Connectors Used
N/A
Additional context
OpenAPITools/openapi-generator#7100 (comment)
cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton
The text was updated successfully, but these errors were encountered: