fix: Open API generator config - protected keyword #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes makes it so that model properties named `protected` will no longer get mangled by the OpenAPI generator into `_protected`. This is needed so that our generated models can be compliant with the JWS RFC [1] Since `protected` is only a softly reserved keyword, this means that you can still declare classes/interfaces with fields that are called `protected` which is what we need since the RFC mentioned above declares exactly that for JWS recipients. [1]: https://tools.ietf.org/html/rfc7515 Fixes hyperledger-cacti#436 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added
bug
petermetz
deleted the
fix/openapi/generator-config-protected-keyword-436
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes makes it so that model properties named
protectedwillno longer get mangled by the OpenAPI generator into
_protected.This is needed so that our generated models can be compliant with the
JWS RFC 1
Since
protectedis only a softly reserved keyword, this means thatyou can still declare classes/interfaces with fields that are called
protectedwhich is what we need since the RFC mentioned abovedeclares exactly that for JWS recipients.
Fixes #436
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com