chore(connector-go-eth): upgrade web3.js to recent version #2089

outSH · 2022-06-21T12:15:52Z

Upgrade web3 package used by go-ethereum-socketio connector from "0.20.7" to "1.8.1"
Major cleanup and refactor of go-ethereum-socketio logic,
without affecting the current functionalities.
Add safety checking of method called in web3Eth and contract functions.
Add tests to check if it works.
Add websocket eth RPC support and some helper functions in openethereum-test-ledger.
Expose WS RPC in geth-testnet, use this port in sample apps
(required to monitor new blocks in updated web3.js)
Change raw use of sendRawTransaction to sendSignedTransaction in sample apps
in order to conform to new web3.js version.
Add safeStringifyException to cactus-common that can be used by validators
to sanitize response errors.
Refactor socketio-based validators to use safeStringifyException.
Adjust connector README files.
Improve cleanup after running sample apps
Fix discounted-cartrade sample ethereum transfer and checking

Closes #2088

Depends on #2053

Signed-off-by: Michal Bajer michal.bajer@fujitsu.com

Please review only the last commit, the rest are dependencies that should be merged in separate PRs.

gitguardian · 2022-06-21T12:16:29Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}}

izuru0

LGTM

takeutak · 2022-06-23T00:32:17Z

@petermetz @jagpreetsinghsasan (cc: @izuru0)
Could you review this PR?

petermetz

@takeutak @outSH Sorry for the slow reviews again. LGTM

@outSH Please fix the conflicts and rebase so that prior to merging it's just the one commit remaining in the PR.

- Add a new package `@hyperledger/cactus-test-verifier-client` for verifier-client stress and functional tests that involve multiple packages. - Add stress test for verifier-client that reports memory usage of repeated operation on `cactus-plugin-ledger-connector-go-ethereum-socketio` connector plugin. - Fix a memory leak in `SocketIOApiClient` - free socket listeners when they are no longer needed. - Fix `cactus-plugin-ledger-connector-go-ethereum-socketio` - use single a web3 connection (with keep-alive/reconnect) instead of spawning new one for each request. Previous solution was causing connection issues in stress testing. Depends on: hyperledger-cacti#2089 Closes: hyperledger-cacti#2189 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

github-actions · 2022-11-23T02:44:49Z

This PR/issue depends on:

~~test(connector-go-ethereum-socketio): add functional test, bug fix #2053~~
By Dependent Issues (🤖). Happy coding!

petermetz

@outSH Please squash+rebase+fix the conflicts

outSH · 2022-11-23T16:54:30Z

Please squash+rebase+fix the conflicts

@petermetz Done, I've also done some improvements in sample apps during testing.

Ready for merging

petermetz

Please squash+rebase+fix the conflicts

@petermetz Done, I've also done some improvements in sample apps during testing.
Ready for merging

@outSH LGTM, thank you very much!

petermetz

Please squash+rebase+fix the conflicts

@petermetz Done, I've also done some improvements in sample apps during testing.

Ready for merging

@outSH LGTM, thank you very much!

petermetz

@outSH Please resolve the merge conflicts and then pass it back for review.

outSH · 2022-11-25T11:28:42Z

@petermetz Done, all should work

petermetz

@outSH LGTM, thank you!

- Upgrade web3 package used by go-ethereum-socketio connector from "0.20.7" to "1.8.1" - Major cleanup and refactor of go-ethereum-socketio logic, without affecting the current functionalities. - Add safety checking of method called in web3Eth and contract functions. Add tests to check if it works. - Add websocket eth RPC support and some helper functions in openethereum-test-ledger. - Expose WS RPC in geth-testnet, use this port in sample apps (required to monitor new blocks in updated web3.js) - Change raw use of sendRawTransaction to sendSignedTransaction in sample apps in order to conform to new web3.js version. - Add safeStringifyException to cactus-common that can be used by validators to sanitize response errors. - Refactor socketio-based validators to use safeStringifyException. - Adjust connector README files. - Improve cleanup after running sample apps - Fix discounted-cartrade sample ethereum transfer and checking Closes hyperledger-cacti#2088 Depends on hyperledger-cacti#2053 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

- Add a new package `@hyperledger/cactus-test-verifier-client` for verifier-client stress and functional tests that involve multiple packages. - Add stress test for verifier-client that reports memory usage of repeated operation on `cactus-plugin-ledger-connector-go-ethereum-socketio` connector plugin. - Fix a memory leak in `SocketIOApiClient` - free socket listeners when they are no longer needed. - Fix `cactus-plugin-ledger-connector-go-ethereum-socketio` - use single a web3 connection (with keep-alive/reconnect) instead of spawning new one for each request. Previous solution was causing connection issues in stress testing. Depends on: hyperledger-cacti#2089 Closes: hyperledger-cacti#2189 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

- Add a new package `@hyperledger/cactus-test-verifier-client` for verifier-client stress and functional tests that involve multiple packages. - Add stress test for verifier-client that reports memory usage of repeated operation on `cactus-plugin-ledger-connector-go-ethereum-socketio` connector plugin. - Fix a memory leak in `SocketIOApiClient` - free socket listeners when they are no longer needed. - Fix `cactus-plugin-ledger-connector-go-ethereum-socketio` - use single a web3 connection (with keep-alive/reconnect) instead of spawning new one for each request. Previous solution was causing connection issues in stress testing. Depends on: #2089 Closes: #2189 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>

outSH requested review from petermetz, takeutak, izuru0, jagpreetsinghsasan and sandeepnRES as code owners June 21, 2022 12:15

github-actions bot added the dependent label Jun 21, 2022

izuru0 approved these changes Jun 22, 2022

View reviewed changes

jagpreetsinghsasan approved these changes Jun 28, 2022

View reviewed changes

petermetz approved these changes Jul 20, 2022

View reviewed changes

outSH mentioned this pull request Nov 7, 2022

test(verifier-client): add stress test and fix a memory leak #2190

Merged

github-actions bot removed the dependent label Nov 23, 2022

petermetz requested changes Nov 23, 2022

View reviewed changes

outSH mentioned this pull request Nov 23, 2022

test(connector-sawtooth-socketio): add functional test, bug fix #2111

Merged

outSH force-pushed the go-ethereum-sdk-upgrade_pr branch from 39a463a to db6a2c7 Compare November 23, 2022 16:47

outSH requested review from petermetz and removed request for sandeepnRES and takeutak November 23, 2022 16:54

petermetz approved these changes Nov 23, 2022

View reviewed changes

petermetz requested changes Nov 24, 2022

View reviewed changes

outSH force-pushed the go-ethereum-sdk-upgrade_pr branch from db6a2c7 to dcdd9ab Compare November 25, 2022 11:28

outSH requested a review from petermetz November 25, 2022 11:28

petermetz approved these changes Nov 26, 2022

View reviewed changes

petermetz force-pushed the go-ethereum-sdk-upgrade_pr branch from dcdd9ab to 6303544 Compare November 26, 2022 17:17

petermetz merged commit 9dd13cb into hyperledger-cacti:main Nov 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(connector-go-eth): upgrade web3.js to recent version #2089

chore(connector-go-eth): upgrade web3.js to recent version #2089

outSH commented Jun 21, 2022 •

edited

Loading

gitguardian bot commented Jun 21, 2022 •

edited

Loading

izuru0 left a comment

takeutak commented Jun 23, 2022

petermetz left a comment

github-actions bot commented Nov 23, 2022

petermetz left a comment

outSH commented Nov 23, 2022

petermetz left a comment

petermetz left a comment

petermetz left a comment

outSH commented Nov 25, 2022

petermetz left a comment

chore(connector-go-eth): upgrade web3.js to recent version #2089

chore(connector-go-eth): upgrade web3.js to recent version #2089

Conversation

outSH commented Jun 21, 2022 • edited Loading

gitguardian bot commented Jun 21, 2022 • edited Loading

️✅ There are no secrets present in this pull request anymore.

izuru0 left a comment

Choose a reason for hiding this comment

takeutak commented Jun 23, 2022

petermetz left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 23, 2022

petermetz left a comment

Choose a reason for hiding this comment

outSH commented Nov 23, 2022

petermetz left a comment

Choose a reason for hiding this comment

petermetz left a comment

Choose a reason for hiding this comment

petermetz left a comment

Choose a reason for hiding this comment

outSH commented Nov 25, 2022

petermetz left a comment

Choose a reason for hiding this comment

outSH commented Jun 21, 2022 •

edited

Loading

gitguardian bot commented Jun 21, 2022 •

edited

Loading