Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-sawtooth-socketio): add functional test, bug fix #2111

Merged
merged 1 commit into from
Nov 24, 2022
Merged

test(connector-sawtooth-socketio): add functional test, bug fix #2111

merged 1 commit into from
Nov 24, 2022

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jul 1, 2022

  • Add functional test of all functions from sawtooth-socketio validator.
  • Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
  • Add stopMonitor to terminate tests easily.
  • Allow multiple clients to monitor for blocks.
  • Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: #2107

Depends on: #2109
Depends on: #2110
Depends on: #2047

Signed-off-by: Michal Bajer michal.bajer@fujitsu.com

@gitguardian
Copy link

gitguardian bot commented Jul 1, 2022 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

izuru0
izuru0 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outSH
Copy link
Contributor Author

outSH commented Nov 21, 2022

@petermetz Rebased and tested with current main - please review

@outSH outSH requested review from petermetz and removed request for sandeepnRES and takeutak November 21, 2022 09:12
@outSH outSH requested a review from petermetz November 22, 2022 16:03
petermetz
petermetz approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH LGTM, please update the package.json/tsconfig.json files either in this or that other bigger PR you mentioned when you can (I'm fine either way)

@petermetz petermetz force-pushed the sawtooth_test_pr branch 2 times, most recently from 8f1ee01 to 0491747 Compare November 22, 2022 22:47
@outSH
Copy link
Contributor Author

outSH commented Nov 23, 2022

Yeah I'm slowly but surely trying to get us to a state where all packages are as uniform as possible in terms of build configuration to make everybody's lives easier and this would be a part of that so thank you very much for offering. I'm totally fine with doing a separate and bigger PR with all of them, so I'll approve this one as-is and leave it up to you how you want to do it for this specific package. Thank you again!

@petermetz I've created a task for it here - #2216. I think I'll take care of it after following PR are merged (to limit the merging headaches):

So please merge this when possible, thanks :)

@petermetz
Copy link
Contributor

Yeah I'm slowly but surely trying to get us to a state where all packages are as uniform as possible in terms of build configuration to make everybody's lives easier and this would be a part of that so thank you very much for offering. I'm totally fine with doing a separate and bigger PR with all of them, so I'll approve this one as-is and leave it up to you how you want to do it for this specific package. Thank you again!

@petermetz I've created a task for it here - #2216. I think I'll take care of it after following PR are merged (to limit the merging headaches):

So please merge this when possible, thanks :)

@outSH Got it, I'll merge this today then. Cheers!

@outSH @petermetz
test(connector-sawtooth-socketio): add functional test, bug fix
246a971 
- Add functional test of all functions from sawtooth-socketio validator.
- Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
- Add stopMonitor to terminate tests easily.
- Allow multiple clients to monitor for blocks.
- Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: hyperledger-cacti#2107

Depends on: hyperledger-cacti#2109
Depends on: hyperledger-cacti#2110
Depends on: hyperledger-cacti#2047

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@petermetz petermetz merged commit 8867830 into hyperledger-cacti:main Nov 24, 2022
@outSH outSH deleted the sawtooth_test_pr branch November 24, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz petermetz approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan approved these changes

@izuru0 izuru0 izuru0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test(connector-go-sawtooth-socketio): add Jest tests
4 participants
@outSH @petermetz @jagpreetsinghsasan @izuru0