refactor(connector-sawtooth-socketio): fix strict flag warnings #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jul 1, 2022
- Add functional test of all functions from sawtooth-socketio validator. - Refactor sawtooth validator to allow importing as a module, to simplify the functional test. - Add stopMonitor to terminate tests easily. - Allow multiple clients to monitor for blocks. - Fix parsing of URL from config so that it doesn't depend on trailing slash anymore. Closes: hyperledger-cacti#2107 Depends on: hyperledger-cacti#2109 Depends on: hyperledger-cacti#2110 Depends on: hyperledger-cacti#2047 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
jagpreetsinghsasan
approved these changes
Jul 6, 2022
cactus-plugin-ledger-connector-sawtooth-socketio will compile with global strict flag. Related issue: hyperledger-cacti#1671 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
force-pushed
the
fix_sawtooth_strict_warn_pr
branch
from
3cbf137 to
e256027
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Nov 21, 2022
- Add functional test of all functions from sawtooth-socketio validator. - Refactor sawtooth validator to allow importing as a module, to simplify the functional test. - Add stopMonitor to terminate tests easily. - Allow multiple clients to monitor for blocks. - Fix parsing of URL from config so that it doesn't depend on trailing slash anymore. Closes: hyperledger-cacti#2107 Depends on: hyperledger-cacti#2109 Depends on: hyperledger-cacti#2110 Depends on: hyperledger-cacti#2047 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Nov 22, 2022
- Add functional test of all functions from sawtooth-socketio validator. - Refactor sawtooth validator to allow importing as a module, to simplify the functional test. - Add stopMonitor to terminate tests easily. - Allow multiple clients to monitor for blocks. - Fix parsing of URL from config so that it doesn't depend on trailing slash anymore. Closes: hyperledger-cacti#2107 Depends on: hyperledger-cacti#2109 Depends on: hyperledger-cacti#2110 Depends on: hyperledger-cacti#2047 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Nov 22, 2022
- Add functional test of all functions from sawtooth-socketio validator. - Refactor sawtooth validator to allow importing as a module, to simplify the functional test. - Add stopMonitor to terminate tests easily. - Allow multiple clients to monitor for blocks. - Fix parsing of URL from config so that it doesn't depend on trailing slash anymore. Closes: hyperledger-cacti#2107 Depends on: hyperledger-cacti#2109 Depends on: hyperledger-cacti#2110 Depends on: hyperledger-cacti#2047 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Nov 23, 2022
- Add functional test of all functions from sawtooth-socketio validator. - Refactor sawtooth validator to allow importing as a module, to simplify the functional test. - Add stopMonitor to terminate tests easily. - Allow multiple clients to monitor for blocks. - Fix parsing of URL from config so that it doesn't depend on trailing slash anymore. Closes: hyperledger-cacti#2107 Depends on: hyperledger-cacti#2109 Depends on: hyperledger-cacti#2110 Depends on: hyperledger-cacti#2047 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
that referenced
this pull request
Nov 24, 2022
- Add functional test of all functions from sawtooth-socketio validator. - Refactor sawtooth validator to allow importing as a module, to simplify the functional test. - Add stopMonitor to terminate tests easily. - Allow multiple clients to monitor for blocks. - Fix parsing of URL from config so that it doesn't depend on trailing slash anymore. Closes: #2107 Depends on: #2109 Depends on: #2110 Depends on: #2047 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cactus-plugin-ledger-connector-sawtooth-socketio will compile with global strict flag.
Related issue: #1671
Signed-off-by: Michal Bajer michal.bajer@fujitsu.com