test(connector-fabric): fix flaky test 2.2.x deploy-cc-from-javascript #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
|
FYI: I've split this into 2 commits because one of them is an important bug-fix (that I uncovered while investigating the test flake) while the rest of the diff is much bigger and not an actual bug fix (just addresses the flakiness of the test but does not fix bug in the production code at all) This way the bug-fix will show up in the release notes when they get generated. |
petermetz
changed the title
petermetz
force-pushed
the
petermetz/issue1471
branch
from
22aecbc
to
26dc510
Compare
jagpreetsinghsasan
approved these changes
Aug 21, 2023
The "express-openapi-validator" package was crashing while trying to parse our Fabric connector's Open API spec because of the typo that in the specs the "description" field for some schema elements were named "properties" which is a reserved field in the schema of the specs. Fixing the typo in the spec document made the problem go away. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Primary changes: --------------- 1. Added robust debug logging to the express middleware of the API server so that problems like this are easier to debug in the future (e.g. trouble with the Open API spec documents themselves) 2. Refactored the ci.yaml document so that there are separate jobs for each tape based Fabric connector integration test. This has reduced (or potentially eliminated) the presence of the flake that we were encountering during the contract deployment test cases. It also has the upside of faster CI because of more parallelism in the CI jobs. 3. Updated the assertions in a couple of test cases where the newer Fabric versions were causing the assertions to fail because the returned JSON response in the example asset transfer chaincode is now referring to the asset owner via a property named "Owner" not "owner" (casing difference) Fixes hyperledger-cacti#1471 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue1471
branch
from
26dc510
to
7362183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary changes:
so that problems like this are easier to debug in the future (e.g.
trouble with the Open API spec documents themselves)
each tape based Fabric connector integration test. This has reduced
(or potentially eliminated) the presence of the flake that we were
encountering during the contract deployment test cases. It also has the
upside of faster CI because of more parallelism in the CI jobs.
versions were causing the assertions to fail because the returned JSON
response in the example asset transfer chaincode is now referring to the
asset owner via a property named "Owner" not "owner" (casing difference)
Fixes #1471
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com