Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-fabric): fix flaky test 2.2.x deploy-cc-from-javascript #2628

Merged
merged 2 commits into from
Aug 21, 2023
Merged

test(connector-fabric): fix flaky test 2.2.x deploy-cc-from-javascript #2628

merged 2 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. fix(connector-fabric): runTransactionV1 Open API validation crash 

    The "express-openapi-validator" package was crashing while trying to
parse our Fabric connector's Open API spec because of the typo that
in the specs the "description" field for some schema elements were named
"properties" which is a reserved field in the schema of the specs.

Fixing the typo in the spec document made the problem go away.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    @petermetz
    petermetz committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8b048d9 View commit details
    Browse the repository at this point in the history

  2. test(connector-fabric): fix flaky test 2.2.x deploy-cc-from-javascript 

    Primary changes:
---------------

1. Added robust debug logging to the express middleware of the API server
so that problems like this are easier to debug in the future (e.g.
trouble with the Open API spec documents themselves)
2. Refactored the ci.yaml document so that there are separate jobs for
each tape based Fabric connector integration test. This has reduced
(or potentially eliminated) the presence of the flake that we were
encountering during the contract deployment test cases. It also has the
upside of faster CI because of more parallelism in the CI jobs.
3. Updated the assertions in a couple of test cases where the newer Fabric
versions were causing the assertions to fail because the returned JSON
response in the example asset transfer chaincode is now referring to the
asset owner via a property named "Owner" not "owner" (casing difference)

Fixes hyperledger-cacti#1471

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    @petermetz
    petermetz committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    7362183 View commit details
    Browse the repository at this point in the history