Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sending Aries messages #250

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Dec 25, 2020

  • Remove logic around sending Aries message from AgentInfo. Instead move this logic as part of DidDoc implementation.
  • Don't use httpclient of agency to send Aries messages. This causes some duplication, but otherwise causes dependency of DDO on Agency which is odd. We could later perhaps have some shared "commons" crate.

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@codecov-io
Copy link

codecov-io commented Dec 25, 2020

Codecov Report

Merging #250 (6523946) into breaking/proof-request-message (605e3d4) will decrease coverage by 0.01%.
The diff coverage is 48.14%.

Impacted file tree graph

@@                        Coverage Diff                         @@
##           breaking/proof-request-message     #250      +/-   ##
==================================================================
- Coverage                           57.90%   57.89%   -0.02%     
==================================================================
  Files                                 149      149              
  Lines                               19708    19715       +7     
  Branches                             4418     4421       +3     
==================================================================
+ Hits                                11412    11414       +2     
- Misses                               4967     4972       +5     
  Partials                             3329     3329              
Flag Coverage Δ
integration 26.51% <18.51%> (+<0.01%) ⬆️
unittests 52.11% <48.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/aries/handlers/connection/agent_info.rs 57.60% <ø> (+0.46%) ⬆️
...es/handlers/connection/invitee/states/requested.rs 55.55% <0.00%> (ø)
...ries/handlers/connection/inviter/states/invited.rs 54.16% <0.00%> (ø)
libvcx/src/aries/handlers/connection/util.rs 37.50% <0.00%> (ø)
libvcx/src/aries/messages/connection/did_doc.rs 77.20% <25.00%> (-1.98%) ⬇️
...aries/handlers/connection/inviter/state_machine.rs 70.37% <50.00%> (ø)
...aries/handlers/connection/invitee/state_machine.rs 71.93% <66.66%> (+0.34%) ⬆️
libvcx/src/aries/handlers/connection/connection.rs 53.72% <100.00%> (ø)
...ies/handlers/connection/invitee/states/complete.rs 86.00% <100.00%> (ø)
...ies/handlers/connection/inviter/states/complete.rs 86.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605e3d4...6523946. Read the comment docs.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@mirgee mirgee merged commit 6d7e4c1 into breaking/proof-request-message Jan 5, 2021
@mirgee mirgee deleted the refactor/send-message branch January 5, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants