Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/sending messages #255

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Refactor/sending messages #255

merged 2 commits into from
Jan 6, 2021

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jan 6, 2021

Recreated PR #250 so we can rather merge it into master for sake of release changelog clarity.

  • Remove logic around sending Aries message from AgentInfo. Instead move this logic as part of DidDoc implementation.
  • Don't use httpclient of agency to send Aries messages. This causes some duplication, but otherwise causes dependency of DDO on Agency which is odd. We could later perhaps have some shared "commons" crate.

Signed-off-by: Patrik Stas patrik.stas@absa.africa

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner January 6, 2021 11:42
@codecov-io
Copy link

Codecov Report

Merging #255 (7c2d7d4) into master (85f6808) will decrease coverage by 5.82%.
The diff coverage is 28.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   57.91%   52.09%   -5.83%     
==========================================
  Files         149      148       -1     
  Lines       19766    18776     -990     
  Branches     4435     4283     -152     
==========================================
- Hits        11448     9781    -1667     
- Misses       4973     5952     +979     
+ Partials     3345     3043     -302     
Flag Coverage Δ
integration ?
unittests 52.09% <28.81%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/aries/handlers/connection/agent_info.rs 57.60% <ø> (+0.87%) ⬆️
...es/handlers/connection/invitee/states/requested.rs 40.74% <0.00%> (-14.82%) ⬇️
...ries/handlers/connection/inviter/states/invited.rs 54.16% <0.00%> (ø)
libvcx/src/aries/handlers/connection/util.rs 37.50% <0.00%> (ø)
...ibvcx/src/aries/handlers/issuance/holder/holder.rs 56.00% <ø> (+4.57%) ⬆️
...aries/handlers/proof_presentation/prover/prover.rs 60.63% <ø> (-14.37%) ⬇️
...essages/proof_presentation/presentation_request.rs 75.00% <ø> (-4.17%) ⬇️
libvcx/src/connection.rs 60.81% <ø> (-1.00%) ⬇️
libvcx/src/disclosed_proof.rs 65.50% <0.00%> (-1.83%) ⬇️
libvcx/src/credential.rs 49.81% <6.66%> (-2.16%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f6808...7c2d7d4. Read the comment docs.

@mirgee mirgee merged commit 19a7ed3 into master Jan 6, 2021
@mirgee mirgee deleted the refactor/sending-messages branch January 6, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants