Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust toolchain from 1.40.0 to 1.45.2 #44

Closed
wants to merge 3 commits into from
Closed

Update rust toolchain from 1.40.0 to 1.45.2 #44

wants to merge 3 commits into from

Conversation

Patrik-Stas
Copy link
Contributor

No description provided.

mirgee
mirgee reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@mirgee mirgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delaying review after #45 is merged due to regression in rust toolchain stable build

mirgee
mirgee reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@mirgee mirgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Rust toolchain version to the latest no affected by the regression, in iOS build as well, so that logs are not spammed with '+cyclone' is not a recognized feature for this target (ignoring feature).

@mirgee mirgee mentioned this pull request Aug 18, 2020
Merged
@Patrik-Stas Patrik-Stas deleted the rust/update_1.45.2 branch October 16, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirgee mirgee mirgee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patrik-Stas @mirgee