-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize UniFFI demo and scripts #896
Conversation
swaptr
commented
Jul 10, 2023
- Initializes the base for building and testing uniffi demo application.
- Added convenience scripts for setting up and compiling uniffi_aries_vcx project for android.
@gmulhearn While building the bindings using the
For reference, I have set up the toolchain using scripts inside the |
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
=======================================
Coverage 44.44% 44.45%
=======================================
Files 417 417
Lines 28975 28975
Branches 6176 6176
=======================================
+ Hits 12879 12880 +1
+ Misses 12297 12296 -1
Partials 3799 3799
Flags with carried forward coverage won't be shown. Click here to find out more. |
As discussed, the solution may be:
|
e7213d6
to
2d40e6c
Compare
You are absolutely correct @gmulhearn. This fixed it right away. Thanks. |
db8a403
to
784acc0
Compare
784acc0
to
a59ee90
Compare
7607f91
to
52495b4
Compare
e79c1c0
to
56d563c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! nice work. As we know, this is all in a WIP state, but it's a good base for the next PRs to pull everything together.
nice work. no need to address the comment i left in this PR, we will handle it in the next PR
uniffi_aries_vcx/demo/app/src/main/java/org/hyperledger/ariesvcx/MainActivity.kt
Show resolved
Hide resolved
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
56d563c
to
0a6fe68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Just one thing, can you add brief instructions for the build steps and running in android? For starter doesn't need to be super detailed, but to give me idea how to proceed if I want to try it out.
Also mention the current state of support - what architectures are supporter, or whether the builds work emulator / physical device.
@gmulhearn feel free to merge at your discretion
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
5bd34cc
to
b84c65d
Compare