Remove libvcx-c, libvcx java, libvcx ios #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
force-pushed
the
remove/libvcx-c
branch
from
34ac7df to
51fcd2c
Compare
Merged
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
remove/libvcx-c
branch
from
51fcd2c to
1d40be1
Compare
Codecov Report
@@ Coverage Diff @@
## main #943 +/- ##
=======================================
Coverage 44.25% 44.25%
=======================================
Files 418 418
Lines 29311 29311
Branches 6262 6262
=======================================
Hits 12972 12972
Misses 12512 12512
Partials 3827 3827
Flags with carried forward coverage won't be shown. Click here to find out more. |
:-) the CI will be also probably a lot faster, got slimmer by considerable number of jobs |
Best comment I’ve ever seen on a PR. |
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
remove/libvcx-c
branch
from
1bb9ca0 to
1cfeaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After ~9 months of deprecation, we remove libvcx-c and associated java and ios wrappers.
However, anyone with strong interest to keep this components "alive" is welcome to take owner their ownership and maintenance. Please contact us if you are interested and we can provide some guidance.
However, recommended strategy for mobile devices is building custom FFI layer on top of aries-vcx crate. There's project in progress #896 demonstrating such approaching using UniFFI library. While not complete, it's great starting point for anyone looking to build native, aries enabled, mobile app.