Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow storing resolvers with varying extra fields in the registry #913

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jul 26, 2023

Uses an adaptor which converts the resolved extra fields to a hash map.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #913 (a789199) into main (85d8084) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   44.27%   44.21%   -0.06%     
==========================================
  Files         416      416              
  Lines       29205    29201       -4     
  Branches     6240     6231       -9     
==========================================
- Hits        12930    12912      -18     
- Misses      12466    12483      +17     
+ Partials     3809     3806       -3     
Flag Coverage Δ
unittests-aries-vcx 44.21% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@mirgee mirgee marked this pull request as ready for review August 10, 2023 12:20
Base automatically changed from feature/did-key to main August 10, 2023 13:35
@mirgee mirgee force-pushed the refactor/did-resolver-registry branch from 9323e6c to d89fbf4 Compare August 11, 2023 08:27
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/did-resolver-registry branch from d89fbf4 to a789199 Compare August 11, 2023 08:31
@mirgee mirgee merged commit 2d02db7 into main Aug 11, 2023
38 checks passed
@mirgee mirgee deleted the refactor/did-resolver-registry branch August 11, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants