Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract subset of changes made in #928 #939

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Aug 16, 2023

Extracts changes made to did_doc, did_doc_sov, did_doc_sov, did_peer, and public_key crates in #928. Most of these changes are either consequences of #913 or additions of features found to be useful during #928.

The reason for extracting these changes is that

TODO: Prune

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee marked this pull request as ready for review August 16, 2023 12:46
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #939 (ef7de69) into main (3321031) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
- Coverage   44.25%   44.25%   -0.01%     
==========================================
  Files         418      418              
  Lines       29311    29311              
  Branches     6262     6262              
==========================================
- Hits        12973    12972       -1     
- Misses      12512    12513       +1     
  Partials     3826     3826              
Flag Coverage Δ
unittests-aries-vcx 44.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
public_key/src/key.rs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

@mirgee mirgee merged commit 730c1e1 into main Aug 16, 2023
39 checks passed
@mirgee mirgee deleted the feature/extract-ddo-changes-subset branch August 16, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants