Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints and improve formatting #986

Merged
merged 26 commits into from
Sep 21, 2023
Merged

Fix lints and improve formatting #986

merged 26 commits into from
Sep 21, 2023

Conversation

bobozaur
Copy link
Contributor

@bobozaur bobozaur commented Sep 19, 2023

Adds more comprehensive formatting settings as well as tweaking clippy and rustc lints.

The smaller crates have been adjusted and their lints fixed, but bigger ones like aries-vcx or libvcx-core will be treated independently in different PRs since they are the main sources for conflicts.

The declared lints are fairly opinionated, but it's a list that I've been building and use with pretty much all of my projects. They are obviously up for discussion and modifications.

@bobozaur bobozaur force-pushed the fix/lints_and_format branch 5 times, most recently from 927a7ac to 339bb1b Compare September 20, 2023 07:21
@bobozaur bobozaur marked this pull request as ready for review September 20, 2023 07:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #986 (4b6c15b) into main (b722167) will increase coverage by 0.76%.
The diff coverage is 37.86%.

❗ Current head 4b6c15b differs from pull request most recent head 8f7cf87. Consider uploading reports for the commit 8f7cf87 to get more accurate results

@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   29.27%   30.04%   +0.76%     
==========================================
  Files         417      415       -2     
  Lines       26096    26943     +847     
  Branches     5222     5229       +7     
==========================================
+ Hits         7640     8095     +455     
- Misses      16262    16651     +389     
- Partials     2194     2197       +3     
Flag Coverage Δ
unittests-aries-vcx 30.04% <37.86%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
agency_client/src/agency_client.rs 0.00% <0.00%> (ø)
agency_client/src/api/agent.rs 0.00% <0.00%> (ø)
agency_client/src/api/downloaded_message.rs 0.00% <0.00%> (ø)
agency_client/src/api/messaging.rs 0.00% <ø> (ø)
agency_client/src/api/onboarding.rs 0.00% <0.00%> (ø)
agency_client/src/configuration.rs 0.00% <0.00%> (ø)
agency_client/src/errors/error.rs 0.00% <ø> (ø)
agency_client/src/httpclient.rs 0.00% <0.00%> (ø)
agency_client/src/internal/messaging.rs 0.00% <0.00%> (ø)
agency_client/src/messages/a2a_message.rs 0.00% <0.00%> (ø)
... and 184 more

... and 36 files with indirect coverage changes

.rustfmt.toml Show resolved Hide resolved
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but left 1 comments

Cargo.toml Show resolved Hide resolved
@bobozaur bobozaur changed the title Fix/lints and format Fix lints and improve formatting Sep 20, 2023
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
bobozaur and others added 11 commits September 21, 2023 11:45
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
* Fix lints from aries_vcx_core (#988)

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Addressed lints and formatting in aries_vcx.

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
@bobozaur bobozaur force-pushed the fix/lints_and_format branch from b25d388 to 8f7cf87 Compare September 21, 2023 08:45
@bobozaur bobozaur requested a review from mirgee September 21, 2023 10:14
@mirgee mirgee merged commit d507cfe into main Sep 21, 2023
@mirgee mirgee deleted the fix/lints_and_format branch September 21, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants