Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints in aries_vcx #989

Merged
merged 10 commits into from
Sep 21, 2023
Merged

Fix lints in aries_vcx #989

merged 10 commits into from
Sep 21, 2023

Conversation

bobozaur
Copy link
Contributor

PR that addresses lints from aries_vcx crate.

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
@bobozaur bobozaur changed the base branch from main to fix/aries_vcx_core_lints September 20, 2023 12:16
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #989 (b78a0ce) into fix/aries_vcx_core_lints (ea322d6) will decrease coverage by 0.03%.
The diff coverage is 54.25%.

@@                     Coverage Diff                      @@
##           fix/aries_vcx_core_lints     #989      +/-   ##
============================================================
- Coverage                     30.04%   30.02%   -0.03%     
============================================================
  Files                           415      415              
  Lines                         26943    26913      -30     
  Branches                       5229     5231       +2     
============================================================
- Hits                           8095     8080      -15     
+ Misses                        16651    16636      -15     
  Partials                       2197     2197              
Flag Coverage Δ
unittests-aries-vcx 30.02% <54.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aries_vcx/src/common/anoncreds.rs 84.95% <ø> (-0.14%) ⬇️
...vcx/src/common/primitives/credential_definition.rs 57.98% <0.00%> (+1.88%) ⬆️
aries_vcx/src/common/proofs/proof_request.rs 19.88% <0.00%> (ø)
...es_vcx/src/common/proofs/prover/prover_internal.rs 27.92% <0.00%> (ø)
...cx/src/common/proofs/verifier/verifier_internal.rs 35.65% <ø> (ø)
aries_vcx/src/core/profile/vdrtools_profile.rs 0.00% <ø> (ø)
...vcx/src/handlers/connection/mediated_connection.rs 0.00% <ø> (ø)
aries_vcx/src/handlers/out_of_band/receiver.rs 0.00% <0.00%> (ø)
...es_vcx/src/handlers/revocation_notification/mod.rs 0.00% <ø> (ø)
aries_vcx/src/handlers/util.rs 17.30% <ø> (ø)
... and 20 more

... and 1 file with indirect coverage changes

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Base automatically changed from fix/aries_vcx_core_lints to fix/lints_and_format September 21, 2023 08:17
@bobozaur bobozaur merged commit b25d388 into fix/lints_and_format Sep 21, 2023
30 checks passed
@bobozaur bobozaur deleted the fix/aries_vcx_lints branch September 21, 2023 08:43
bobozaur added a commit that referenced this pull request Sep 21, 2023
Addressed lints and formatting in aries_vcx.

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
mirgee pushed a commit that referenced this pull request Sep 21, 2023
* Updated rustfmt.toml

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Added lints section in workspace

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed napi-rs wrapper lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed uniffi_aries_vcx lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed tools crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed public_key crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed indy_ledger_response_parser crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed did_resolver_web lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed did_resolver_sov crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed did_resolver_registry crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed did_peer crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed did_parser crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed did_doc_sov crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed did_doc crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed rust agent lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed agency_client crate lints

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Uniformized toolchain version in CI

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Ran cargo fmt

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Revert Rust toolchain version

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fix code formatting CI check

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* More formatting fixes

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Macro formatting fix

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed ResponseParser construction

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fixed rust agent lints post rebase

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fix lints from aries_vcx_core (#988)

* Fix lints from aries_vcx_core (#988)

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

* Fix lints in aries_vcx (#989)

Addressed lints and formatting in aries_vcx.

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>

---------

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
bobozaur added a commit that referenced this pull request Sep 21, 2023
Addressed lints and formatting in aries_vcx.

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants