-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lints in aries_vcx #989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## fix/aries_vcx_core_lints #989 +/- ##
============================================================
- Coverage 30.04% 30.02% -0.03%
============================================================
Files 415 415
Lines 26943 26913 -30
Branches 5229 5231 +2
============================================================
- Hits 8095 8080 -15
+ Misses 16651 16636 -15
Partials 2197 2197
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
bobozaur
force-pushed
the
fix/aries_vcx_lints
branch
from
September 20, 2023 17:10
74eab33
to
b78a0ce
Compare
Patrik-Stas
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
mirgee
approved these changes
Sep 21, 2023
Base automatically changed from
fix/aries_vcx_core_lints
to
fix/lints_and_format
September 21, 2023 08:17
bobozaur
added a commit
that referenced
this pull request
Sep 21, 2023
Addressed lints and formatting in aries_vcx. Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
mirgee
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Updated rustfmt.toml Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Added lints section in workspace Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed napi-rs wrapper lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed uniffi_aries_vcx lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed tools crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed public_key crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed indy_ledger_response_parser crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed did_resolver_web lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed did_resolver_sov crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed did_resolver_registry crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed did_peer crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed did_parser crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed did_doc_sov crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed did_doc crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed rust agent lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed agency_client crate lints Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Uniformized toolchain version in CI Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Ran cargo fmt Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Revert Rust toolchain version Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fix code formatting CI check Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * More formatting fixes Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Macro formatting fix Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed ResponseParser construction Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fixed rust agent lints post rebase Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fix lints from aries_vcx_core (#988) * Fix lints from aries_vcx_core (#988) Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> * Fix lints in aries_vcx (#989) Addressed lints and formatting in aries_vcx. Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com> --------- Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
bobozaur
added a commit
that referenced
this pull request
Sep 21, 2023
Addressed lints and formatting in aries_vcx. Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that addresses lints from
aries_vcx
crate.