Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more privacy AT support classes #7554

Closed
macfarla opened this issue Sep 2, 2024 · 0 comments · Fixed by #7569
Closed

Remove more privacy AT support classes #7554

macfarla opened this issue Sep 2, 2024 · 0 comments · Fixed by #7569
Assignees
@gtebrean
Labels
good first issue Good for newcomers snack Smaller coding task - less than a day for an experienced dev testing

Comments

@macfarla
Copy link
Contributor

macfarla commented Sep 2, 2024

Since #7530 has merged, there are more classes that were supporting the privacy ATs that are no longer used. for example PrivacyNodeFactory PrivacyAccountResolver and PrivacyCluster no longer have any usages (your IDE can tell you this). There is probably more -
@macfarla macfarla added good first issue Good for newcomers testing snack Smaller coding task - less than a day for an experienced dev labels Sep 2, 2024
@gtebrean gtebrean self-assigned this Sep 3, 2024
@gtebrean gtebrean mentioned this issue Sep 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtebrean gtebrean

Labels
good first issue Good for newcomers snack Smaller coding task - less than a day for an experienced dev testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue - 7554 remove unused privacy test classes gtebrean/besu
2 participants
@macfarla @gtebrean