Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed Privacy ATs #7530

Merged
merged 3 commits into from
Sep 1, 2024
Merged

Conversation

pr9t
Copy link
Contributor

@pr9t pr9t commented Aug 28, 2024

PR description

Fixed Issue(s)

Closes #7347

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
Copy link
Contributor

@pr9t you'll need to add signoff to your commits to satisfy DCO - follow the instructions here https://github.com/hyperledger/besu/pull/7530/checks?check_run_id=29343327854

@macfarla
Copy link
Contributor

(alternatively, you can close this PR and redo your changes with signoff, sometimes frankly that is easier!)

@macfarla
Copy link
Contributor

the change itself looks fine :)

Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
@pr9t pr9t force-pushed the chore/remove-privacy-ats branch from 741aae8 to 9ab99dc Compare August 28, 2024 06:50
@pr9t
Copy link
Contributor Author

pr9t commented Aug 28, 2024

@macfarla I have signed-off my commit in the same PR.

@macfarla
Copy link
Contributor

@pr9t
can you run this locally -
./gradlew compileTestJava
there are a few more classes that extended ParameterizedEnclaveTestBase that need removing as well eg PrivGetPrivateTransactionAcceptanceTest

@macfarla macfarla marked this pull request as draft August 28, 2024 21:40
@macfarla macfarla self-assigned this Aug 28, 2024
…d FlexiblePrivacyAcceptanceTestBase

Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
@pr9t pr9t marked this pull request as ready for review August 30, 2024 03:15
@pr9t
Copy link
Contributor Author

pr9t commented Aug 30, 2024

@macfarla I have removed the classes that extend PrivateLogFilterAcceptanceTest and FlexiblePrivacyAcceptanceTestBase. The results are as follows:

  • unit tests were successful
  • acceptance tests failed
  • The command ./gradlew compileTestJava was successful.

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution @pr9t 🚀

@macfarla macfarla merged commit c915e05 into hyperledger:main Sep 1, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Privacy ATs - have been disabled for some time
2 participants