Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - 7554 remove unused privacy test classes #7569

Merged
merged 19 commits into from
Sep 12, 2024

Conversation

gtebrean
Copy link
Contributor

@gtebrean gtebrean commented Sep 3, 2024

PR description

Fixed Issue(s)

fixes #7554

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@gtebrean gtebrean marked this pull request as draft September 3, 2024 20:10
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
@gtebrean gtebrean marked this pull request as ready for review September 5, 2024 15:05
@gtebrean gtebrean requested a review from macfarla September 5, 2024 15:05
@gtebrean gtebrean added privacy private transactions testing labels Sep 5, 2024
gtebrean and others added 3 commits September 5, 2024 20:39
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gtebrean and others added 2 commits September 12, 2024 10:47
Signed-off-by: George Tebrean <99179176+gtebrean@users.noreply.github.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) September 12, 2024 07:54
@macfarla macfarla merged commit 6ed1db3 into hyperledger:main Sep 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
privacy private transactions testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove more privacy AT support classes
2 participants