Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_estimateGas state overrides #7890

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

macfarla
Copy link
Contributor

PR description

follow on from #7801
allow state/account overrides for eth_estimateGas

Fixed Issue(s)

fixes #5788

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla requested a review from fab-10 November 20, 2024 00:19
@macfarla macfarla enabled auto-merge (squash) November 20, 2024 10:37
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla merged commit 9718fd5 into hyperledger:main Nov 20, 2024
43 checks passed
@macfarla macfarla deleted the eth-estimategas-overrides branch November 21, 2024 00:18
jflo pushed a commit to jflo/besu that referenced this pull request Nov 22, 2024
* parse account overrides parameter for eth_estimateGas

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* changelog

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow state override on eth_call and eth_estimateGas
2 participants