Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_call overrides #7801

Merged
merged 28 commits into from
Nov 19, 2024
Merged

eth_call overrides #7801

merged 28 commits into from
Nov 19, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Oct 23, 2024 •
edited
Loading

PR description

  • add optional parameter to eth_call to represent state overrides: map from Address to AccountOverride

Fixed Issue(s)

Fixes #5788
Note this only implements account overrides - blockOverrides can be a separate PR if required

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla added 19 commits October 22, 2024 11:46
@macfarla
draft
f2f0b87 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
draft
36ee2ff 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
check types
ee630da 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
tinkering with serialization
c8dcb83 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
add comments to test to explain failures
9fa398c 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ethcall-override
7e794ec
@macfarla
foramtting
a2deffe 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
deserialization one step closer
2ad8bf6 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
parameter serialization successful
a640f1d 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ethcall-override
38ba498
@macfarla
tidy up test
68fdc24 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
added extra tests
f63bea6 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ethcall-override
1b7cd4b
@macfarla
fix ethcall tests
99c3846 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
fix ethcall tests
3436c85 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ethcall-override
56c98fc
@macfarla
test cases
f83f1f4 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
apply storage overrides
fec7581 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ethcall-override
bb96d76
@macfarla macfarla marked this pull request as ready for review October 29, 2024 03:35
fab-10
fab-10 reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few little suggestions to review

...um/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCall.java Outdated
@@ -81,10 +87,14 @@ protected Object resultByBlockHash(final JsonRpcRequestContext request, final Ha
protected Object resultByBlockHeader(
final JsonRpcRequestContext request, final BlockHeader header) {
JsonCallParameter callParams = JsonCallParameterUtil.validateAndGetCallParams(request);
// TODO check whether there are any state overrides
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this first TODO is implemented in this PR right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reviewing @fab-10 - have applied those changes if you can take another look

...um/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCall.java Outdated Show resolved Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/TransactionSimulator.java Outdated Show resolved Hide resolved
...reum/core/src/test/java/org/hyperledger/besu/ethereum/util/AccountOverrideParameterTest.java Outdated Show resolved Hide resolved
macfarla and others added 8 commits November 19, 2024 16:03
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ethcall-override
fcad92d
@macfarla
removed TODO that is implemented
9a64862 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla @fab-10
Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/tran…
a021d90 
…saction/TransactionSimulator.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla @fab-10
Update ethereum/core/src/test/java/org/hyperledger/besu/ethereum/util…
c1a0b31 
…/AccountOverrideParameterTest.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla @fab-10
Update ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/j…
521132a 
…sonrpc/internal/methods/EthCall.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
unreachable statement
aa199af 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into ethcall-override
3915cc4
@macfarla
add state and account overrides
2eff15a 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla merged commit 8b7ca20 into hyperledger:main Nov 19, 2024
43 checks passed
This was referenced Nov 19, 2024
Closed
Merged
@macfarla macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 20, 2024
This was referenced Nov 20, 2024
Merged
Merged
@bgravenorst bgravenorst mentioned this pull request Nov 25, 2024
Closed
@bgravenorst bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 25, 2024
@macfarla macfarla deleted the ethcall-override branch December 5, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fab-10 fab-10 fab-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow state override on eth_call and eth_estimateGas
3 participants
@macfarla @fab-10 @bgravenorst