-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(ci): add to the option to skip CI checking #1014
Comments
Can our plan of the CI run several PRs concurrently? |
@takeutak Agreed. We could add a check in the ci.sh script that examines the diff between @RafaelAPB We have the technical capability for that, but at the end of the day we must always execute the tests sequentially to avoid inadvertently merging in bugs that only manifest when two separate PRs are both merged together on main (happened a few times before so that's why I had to configure it in a way that GH always forces you to run the tests against a freshly rebased version of the PR branch) |
…1014 Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
…1014 Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
…1014 Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
…1014 Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
…1014 Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
Is your feature request related to a problem? Please describe.
According to the current configuration, every time a Pull request is merged into the main branch, the CI check must be redone. Considering that it takes more than an hour to complete a CI check, I think that we cannot cope with a situation where the code needs frequent changes.
However, it is not large enough that all code has to be CI checked every time (For example, there is no need to do CI check on pull-requests including only document files, right?). Since CI check is mandatory for all pull-requests, this inconvenience will occur.
Describe the solution you'd like
I would like to be able to choose to avoid CI checks when merging pull-requests. Is it possible to change the specification? @petermetz
The text was updated successfully, but these errors were encountered: