fix(plugin-ledger-connector): Some of the plugin-ledger-connectors are using wrong Interface Types in their class definitions

[m-courtin]

Describe the bug

Some of the plugin-ledger-connectors are using wrong Interface Types in their class definitions where the types for the deployContract() and the transact() functions are getting defined.

To Reproduce

In plugin-ledger-connector-quorum for example the class definition needs to implement "IPluginLedgerConnector<
DeployContractSolidityBytecodeV1Request, DeployContractSolidityBytecodeV1Response,
RunTransactionRequest, RunTransactionResponse >" but the deployContract() is using DeployContractSolidityBytecodeV1Request and RunTransactionResponse instead of the interface definition pair DeployContractSolidityBytecodeV1Request, DeployContractSolidityBytecodeV1Response.

Similar is the case for the besu connector.

Expected behavior

For all the connector class definitions the implementation needs to follow their interface definition and need to match in consistent way for all the connectors.

[petermetz]

Research needs to be done on why the compiler is okay with this and if there's any configuration parameter that would make it so that it does error out. Enforcing these things manually will always be a doomed effort so ideally we'd somehow find a way to have the CI do the heavy lifting instead.

[m-courtin]

Totally agree on this: The compiler should throw error to show to the outside that the required interface type and the implemented type are not matching

[m-courtin]

@petermetz: Can you please assign this issue to me

[m-courtin]

According to my suggestion I will create a branch named "NOT_fixed_1445_for_reproduction_DONT_UPDATE" and a branch for the fix that we can have as sonn as possible a fixed version and in parallel can do researches on the un-fixed branch to find out why the linter / compiler is not complaining

[petermetz]

@m-courtin Sounds good to me. My only nit: keep branches all lower-case if possible. (some git tooling/operating systems do not take kindly to certain edge cases that stem from mixed-case branch names)

[m-courtin]

@petermetz Ok fine, I'll use lower-case only for my branch names